return dsn_empty when there's no dsn config

Author: artemeff

lib/sparrow/catcher.ex

@@ -19,7 +19,7 @@ defmodule Sparrow.Catcher do
     do
       {:ok, id}
     else
-      {:error, :invalid_dsn} ->
+      {:error, :dsn_invalid} ->
         Logger.warn("sparrow has invalid DSN configuration")
 
       any ->

lib/sparrow/client.ex

@@ -65,11 +65,11 @@ defmodule Sparrow.Client do
   end
 
   def get_dsn(opts) do
-    parse_dsn(Keyword.get(opts, :dsn, Sparrow.dsn()))
+    parse_dsn(Keyword.get_lazy(opts, :dsn, &Sparrow.dsn/0))
   end
 
   defp parse_dsn(val) when val in [nil, ""] do
-    {:error, :invalid_dsn}
+    {:error, :dsn_empty}
   end
 
   defp parse_dsn(dsn) do
@@ -78,7 +78,7 @@ defmodule Sparrow.Client do
         {:ok, scheme <> uri <> "/api/store/", public, secret, project}
 
       _ ->
-        {:error, :invalid_dsn}
+        {:error, :dsn_invalid}
     end
   end
 end

test/sparrow_test.exs

@@ -98,6 +98,15 @@ defmodule SparrowTest do
 
       assert {:ok, _id} = Sparrow.capture(message, dsn: "http://public:secret@proxy/service/suffix/31")
     end
+
+    test "returns :dsn_empty when DSN id empty" do
+      assert {:error, :dsn_empty} == Sparrow.capture("test message", dsn: nil)
+      assert {:error, :dsn_empty} == Sparrow.capture("test message", dsn: "")
+    end
+
+    test "returns :dsn_invalid when DSN id invalid" do
+      assert {:error, :dsn_invalid} == Sparrow.capture("test message", dsn: "invalid dsn")
+    end
   end
 
   defp decode(binary) do