[$250] AMEX Company Card reconnect flow completes but connection remains broken

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction (Unable to reproduce, Tried with plaid bank)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ade-constantiniu
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to Company Cards
2. Observe error message: “Card feed connection is broken. Please log in to your bank so we can establish the connection again.”
3. Click to reconnect / log into AMEX
4. Successfully authenticate and link the AMEX account
5. Get redirected back to the Company Cards page
6. Observe the connection status

Expected Result:

After successfully logging into and reconnecting the AMEX account:
The card feed connection should be restored.
The error message should disappear.

Actual Result:

After completing the AMEX login and reconnect flow (multiple times):
The user is redirected back to the Company Cards page.
The same error message remains.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

The video for the issue is in Slack thread

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ShridharGoel

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022028942173847668994
• Upwork Job ID: 2028942173847668994
• Last Price Increase: 2026-03-03

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After completing the AMEX company card reconnect flow (authenticating at the bank successfully and being redirected back), the "Card feed connection is broken" error persists on the Company Cards page. The error never clears even after multiple reconnection attempts.

What is the root cause of that problem?

The useUpdateFeedBrokenConnection hook (App/src/hooks/useUpdateFeedBrokenConnection.ts:21) picks the first broken card from a flat dictionary of ALL broken cards across ALL feeds using .at(0), rather than filtering by the specific feed being reconnected. This has two consequences:

1. Wrong card may be synced: If the user has broken connections on multiple feeds, .at(0) may pick a card from a completely different feed than the AMEX feed the user just reconnected. The SyncCard command then targets the wrong card, leaving the AMEX feed unchanged.

2. Only one card is synced: Even if the correct feed's card is picked, company card feeds typically have multiple cards assigned. If several cards on the AMEX feed have broken lastScrapeResult values, only one card gets the optimistic lastScrapeResult=200 update via updateWorkspaceCompanyCard (App/src/libs/actions/CompanyCards.ts:493). The remaining cards retain their broken status codes, so the per-feed isFeedConnectionBroken flag stays true after recomputation by the derived value at App/src/libs/actions/OnyxDerived/configs/cardFeedErrors.ts:119-145.

A card is considered "broken" when lastScrapeResult exists AND is not in the ignored list [200, 531, 530, 500, 666] (App/src/libs/CardUtils.ts:1056-1058). The per-feed isFeedConnectionBroken uses ||= aggregation — meaning if any card on the feed is broken, the whole feed shows the error banner.

Additionally, the web BankConnection component (App/src/pages/workspace/companyCards/BankConnection/index.tsx) has no active mechanism to detect when the bank auth popup completes. Unlike the native version which monitors WebView URL changes, the web version relies entirely on Pusher-driven Onyx updates to detect that the feed's expiration has been refreshed. If this Pusher update doesn't arrive (or arrives after the user navigates away), updateBrokenConnection() is never called at all.

What changes do you think we should make in order to solve the problem?

1. Filter broken cards by the specific feed being reconnected in useUpdateFeedBrokenConnection — instead of using the global cardsWithBrokenFeedConnection dict, filter it to only include cards belonging to the feed parameter passed to the hook.

2. Sync ALL broken cards on the feed, not just one — instead of .at(0), iterate over all cards on the target feed that have broken connections and call updateWorkspaceCompanyCard for each, or update the SyncCard API usage to accept the feed as a whole rather than a single card ID.

3. Investigate the server-side AMEX OAuth callback to confirm it properly pushes updated feed expiration data via Pusher after successful bank authentication. This is needed to ensure the web BankConnection component can detect auth completion.

The key files to modify:

• App/src/hooks/useUpdateFeedBrokenConnection.ts — filter by feed and handle multiple broken cards
• App/src/libs/actions/OnyxDerived/configs/cardFeedErrors.ts — potentially add a per-feed broken cards mapping (currently only has a global flat dict)

What alternative solutions did you explore? (Optional)

An alternative would be to add popup close detection on the web BankConnection component (polling customWindow.closed or using postMessage) to proactively trigger updateBrokenConnection() when the popup closes, rather than relying solely on Pusher updates. This would address the Pusher timing issue but wouldn't fix the core problem of only syncing one card from the wrong feed.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ShridharGoel (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022028942173847668994

[imgyf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After successfully completing the AMEX reconnect flow (authenticating at the bank and being redirected back), the "Card feed connection is broken" error persists on the Company Cards page.

What is the root cause of that problem?

The useUpdateFeedBrokenConnection hook (src/hooks/useUpdateFeedBrokenConnection.ts) has two bugs that prevent it from correctly clearing a broken connection for the specific feed being reconnected:

1. Uses the global aggregate error state instead of the per-feed state. The hook destructures all: {isFeedConnectionBroken} from useCardFeedErrors() (line 21). This all flag is an OR-aggregate across every feed on every workspace. The per-feed error state already exists in cardFeedErrors[feed] (computed by the derived value at src/libs/actions/OnyxDerived/configs/cardFeedErrors.ts:119-145), but the hook ignores it. This means isFeedConnectionBroken can be true due to a completely unrelated feed, or conversely, could trigger reconnect logic for the wrong reason.

2. Picks the first broken card globally, not from the target feed. Line 24 does Object.entries(cardsWithBrokenFeedConnection).at(0) — this flat dictionary contains broken cards from ALL feeds. The card picked may belong to a different feed than the AMEX feed being reconnected. When updateWorkspaceCompanyCard sends the SyncCard command for that wrong card, the AMEX feed's broken cards are never updated, so isFeedConnectionBroken remains true for the AMEX feed after the derived value recomputes.

What changes do you think we should make in order to solve the problem?

In useUpdateFeedBrokenConnection (src/hooks/useUpdateFeedBrokenConnection.ts):

1. Destructure cardFeedErrors from useCardFeedErrors() in addition to cardsWithBrokenFeedConnection. Use cardFeedErrors[feed]?.isFeedConnectionBroken as the returned isFeedConnectionBroken value instead of all.isFeedConnectionBroken. This scopes the broken-connection check to the specific feed being managed.

2. Filter cardsWithBrokenFeedConnection to only include cards that belong to the target feed. Each card in the dict has a bank property and a fundID (workspace account ID) — use getCardFeedWithDomainID(card.bank, card.fundID) to compute the card's feed key and compare it against the feed parameter.

3. In updateBrokenConnection, iterate over ALL filtered broken cards for the target feed and call updateWorkspaceCompanyCard for each one, rather than only the first. Since isFeedConnectionBroken in the derived value uses ||= aggregation across all cards in a feed, leaving even one card with a broken lastScrapeResult keeps the error banner visible.

What alternative solutions did you explore? (Optional)

Clearing the feed's error state optimistically on the client when the reconnect popup closes — but on web, there's no reliable way to detect popup closure (the native version monitors WebView URL changes, but BankConnection/index.tsx opens a plain window.open popup with no close detection). The SyncCard approach correctly triggers a server-side re-scrape that produces authoritative Pusher updates.