[$250] Android - Reports - App crashes when opening Reports > Approve

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3391/folder/13176922/43675713/1146029647?q=reports&issue_type=jira
Email or phone of affected tester (no customers): sodijnsodijsodijsoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Log in with a new account.
3. Complete onboarding.
4. Create a workspace.
5. Go to Reports > Approve.
6. Kill app.
7. Relaunch app.
8. Go to Reports > Approve.
9. Might need to repeat Step 2 to 5 a few times until it crashes.

Expected Result:

App will not crash when opening Reports > Approve.

Actual Result:

App crashes when opening Reports > Approve.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022015916608067392040
• Upwork Job ID: 2015916608067392040
• Last Price Increase: 2026-02-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.

The Android app crashes when opening Reports > Approve after the app is killed and opened again. This happens because the Search page reads user data during startup when the data is not fully ready.

What is the root cause of that problem?

The earliest wrong assumption is that accountID is always defined when currentUserPersonalDetails exists. In SearchPage.tsx, the code calls accountID.toString() without optional chaining on accountID. When the object exists but accountID is still undefined during partial hydration, calling toString() throws a TypeError and causes the crash.

What changes do you think we should make in order to solve the problem?

• Update the accountID access to use optional chaining in src/pages/SearchPage.tsx.
• This avoids calling toString() when accountID is undefined.
• Keep the rest of the logic the same.

File: src/pages/SearchPage.tsx

// ... existing code ...
const queryJSON = useMemo(() => buildSearchQueryJSON(route.params.q, route.params.rawQuery), [route.params.q, route.params.rawQuery]);
const {saveScrollOffset} = useContext(ScrollOffsetContext);

const activeAdminPolicies = getActiveAdminWorkspaces(
    policies,
    currentUserPersonalDetails?.accountID?.toString()
).sort((a, b) => localeCompare(a.name || '', b.name || ''));

const expensifyIcons = useMemoizedLazyExpensifyIcons([
    'Export',
    'Table',
]);
// ... existing code ...

What alternative solutions did you explore? (Optional)

I considered forcing useCurrentUserPersonalDetails to always return a full object. This was not chosen because the data loads asynchronously and this would add risk in other places. Fixing the access in SearchPage.tsx is smaller and safer.

[rohit9625]

Were you able to reproduce this issue @yatin-italy?