[$250] Reports - Infinite loading after merging expenses while in offline mode.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.92-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77623
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 / Chrome (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create two manual expenses on two different reports.
4. Navigate to "Reports" > "Expenses"
5. Turn off internet connection.
6. Select one of the just created expenses.
7. Click on the dropdown menu and select "Merge"
8. Select the second expense.
9. Keep all the details of the second expense and merge the expenses.
10. Note that infinite loading is experienced when the merging process is finished.

Expected Result:

After merging expenses while on "Reports", user should be correctly navigated to the report of the kept expense and all the details should be visible.

Actual Result:

After merging expenses while offline on "Expenses" section on "Reports", infinite loading is experienced when report of the kept expense opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7040828_1767415162228.Infinite.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022008024143018758003
• Upwork Job ID: 2008024143018758003
• Last Price Increase: 2026-02-18

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After merging two expenses while in offline mode from the Reports > Expenses page, when navigating to the report of the kept expense, users experience infinite loading. The page never finishes loading and the expense details are not displayed.

What is the root cause of that problem?

When merging transactions, the function creates optimistic data to update Onyx immediately. However, it doesn't include an optimistic update for the target transaction's report metadata to set isLoadingInitialReportActions to false.

The SearchMoneyRequestReportPage relies on reportMetadata.isLoadingInitialReportActions being false to stop showing the loading state. Without this optimistic update:

1. User merges two expenses while offline
2. The merge completes optimistically, navigating to the target expense's report
3. SearchMoneyRequestReportPage mounts and checks reportMetadata.isLoadingInitialReportActions
4. Since no optimistic data was set for this flag, it remains true (or undefined, which is treated as loading)
5. The page waits indefinitely for the flag to become false, showing infinite loading
6. In online mode, the API response eventually sets the flag, but offline this never happens

What changes do you think we should make in order to solve the problem?

Add an optimistic update for the target transaction's report metadata in the mergeTransactionRequest function to set isLoadingInitialReportActions to false.

in mergeTransactionRequest after the failureTransactionViolations definition, add

// Set report metadata to ensure the target report doesn't show loading state after merge
const optimisticReportMetadata: OnyxUpdate = {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${targetTransaction.reportID}`,
    value: {
        isLoadingInitialReportActions: false,
    },
};

Then include this in the optimisticData array:

const optimisticData: OnyxUpdate[] = [
    ...(onyxTargetTransactionData.optimisticData ?? []),
    optimisticSourceTransactionData,
    ...optimisticSourceReportData,
    optimisticMergeTransactionData,
    ...optimisticTransactionViolations,
    ...optimisticSourceReportActionData,
    optimisticReportMetadata,
];

What alternative solutions did you explore? (Optional)

Modify SearchMoneyRequestReportPage to handle undefined isLoadingInitialReportActions as false instead of true. However, this could cause issues in other scenarios where we actually want to show loading until the flag is explicitly set.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports infinitely load after merging an expense while online

What is the root cause of that problem?

The loading skeleton is displayed because we delete the wrong report when merging two reports, causing the report to become undefined.

App/src/libs/actions/MergeTransaction.ts

Lines 346 to 347 in f7265ef

	key: `${ONYXKEYS.COLLECTION.REPORT}${sourceTransaction.reportID}`,
	value: null,

This happens because we pass an incorrect parameter to mergeTransactionRequest:

App/src/pages/TransactionMerge/ConfirmationPage.tsx

Lines 66 to 70 in f7265ef

	mergeTransactionRequest({
	mergeTransactionID: transactionID,
	mergeTransaction,
	targetTransaction,
	sourceTransaction,

A user can select a different target report, but the data flow assumes that the currently opened report is the target report. As a result, the wrong report is deleted by the optimistic update above.

What changes do you think we should make in order to solve the problem?

We should swap the source and target transactions based on the selected report field on the merge review page.

In Confirmation details page:

App/src/pages/TransactionMerge/ConfirmationPage.tsx

Lines 66 to 70 in f7265ef

	mergeTransactionRequest({
	mergeTransactionID: transactionID,
	mergeTransaction,
	targetTransaction,
	sourceTransaction,

We modify the code to be:

const shouldSwap = (sourceTransaction?.reportID !== targetTransaction?.reportID) && (reportID === sourceTransaction?.reportID);

let targetTransactionData = shouldSwap ? sourceTransaction : targetTransaction;
let sourceTransactionData = shouldSwap ? targetTransaction : sourceTransaction;
let mergeTransactionData = {
    ...mergeTransaction,
    sourceTransactionID: sourceTransactionData.transactionID,
    targetTransactionID: targetTransactionData.transactionID
};

setIsMergingExpenses(true);

mergeTransactionRequest({
    mergeTransactionID: transactionID,
    mergeTransaction: mergeTransactionData,
    targetTransaction: targetTransactionData,
    sourceTransaction: sourceTransactionData,
    .....

Maybe need additional testing on the shouldSwap check.

Result:

test_d.mp4

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022008024143018758003

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[twinkle-react]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.