[Due for payment 2026-01-30] [$250] When auto-reporting is disabled and recipient is user, Attendee field appears on confirm page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.63-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-1965/folder/13176730/56792088/1013856509
Email or phone of affected tester (no customers): sndiojsojsdisjd2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Turn off Submission frequency, Add approvals and Make or track payments in Workflows settings.
• Attendee tracking is enabled in workspace settings > Rules.

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual.
3. Enter amount > Next.
4. On confirm page, click To field.
5. Enter any email and select the user.

Expected Result:

When auto-reporting is disabled and recipient is a user, Attendee field will not appear on confirm page.

Actual Result:

When auto-reporting is disabled and recipient is a user, Attendee field appears on confirm page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993461058376703210
• Upwork Job ID: 1993461058376703210
• Last Price Increase: 2025-11-25

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When auto-reporting is disabled and recipient is a user, Attendee field appears on confirm page.

What is the root cause of that problem?

The shouldShowAttendees function only checked if:

• The policy has attendee tracking enabled
• The iouType is SUBMIT or CREATE
• The policy type is CORPORATE

However, it did NOT check whether the recipient is actually a workspace. When a user selected a personal user as the recipient, the function would still return true if the user had a default workspace with attendee tracking enabled.

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 299 in 4bc3b20

const shouldShowAttendees = useMemo(() => shouldShowAttendeesTransactionUtils(iouType, policy), [iouType, policy]);

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 297 in 2269f56

const shouldShowAttendees = useMemo(() => shouldShowAttendeesTransactionUtils(iouType, policy), [iouType, policy]);

What changes do you think we should make in order to solve the problem?

We update shouldShowAttendees calculation in two components to also check isPolicyExpenseChat

    const shouldShowAttendees = useMemo(() => isPolicyExpenseChat && shouldShowAttendeesTransactionUtils(iouType, policy), [isPolicyExpenseChat, iouType, policy]);

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 299 in 4bc3b20

const shouldShowAttendees = useMemo(() => shouldShowAttendeesTransactionUtils(iouType, policy), [iouType, policy]);

    const shouldShowAttendees = useMemo(() => isPolicyExpenseChat && shouldShowAttendeesTransactionUtils(iouType, policy), [isPolicyExpenseChat, iouType, policy]);

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 297 in 2269f56

const shouldShowAttendees = useMemo(() => shouldShowAttendeesTransactionUtils(iouType, policy), [iouType, policy]);

Note: We can modify inside shouldShowAttendeesTransactionUtils if needed, and can update other places if they have same issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When auto-reporting is disabled and recipient is user, Attendee field appears on confirm page

What is the root cause of that problem?

Here is function for check:

App/src/libs/TransactionUtils/index.ts

Lines 451 to 462 in b2d6b8c

	/**
	* Determine if we should show the attendee selector for a given expense on a give policy.
	*/
	function shouldShowAttendees(iouType: IOUType, policy: OnyxEntry<Policy>): boolean {
	if ((iouType !== CONST.IOU.TYPE.SUBMIT && iouType !== CONST.IOU.TYPE.CREATE) || !policy?.id || policy?.type !== CONST.POLICY.TYPE.CORPORATE) {
	return false;
	}
	// For backwards compatibility with Expensify Classic, we assume that Attendee Tracking is enabled by default on
	// Control policies if the policy does not contain the attribute
	return policy?.isAttendeeTrackingEnabled ?? true;
	}

But we dont check here for autoreporting, and is it policyExpenseChat

What changes do you think we should make in order to solve the problem?

We should check it:

 return (policy?.isAttendeeTrackingEnabled ?? true) && !!policy?.autoReporting && isPolicyExpenseChat;

PS: pass isPolicyExpenseChat to props and update all references

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993461058376703210

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When auto-reporting is disabled and recipient is a user, Attendee field appears on confirm page.

What is the root cause of that problem?

When the confirmation page is mounted, an Onyx connection is created for the report key here.

App/src/pages/iou/request/step/withWritableReportOrNotFound.tsx

Line 67 in 29e1abf

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${route.params.reportID}`, {canBeMissing: true});

After going back from the participant page, route.params.reportID is changed. The useOnyx hook still returns the value of the previous key. So the policyID here is still a valid policy and then the attendee is still shown based on the condition here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 180 in 29e1abf

const policyID = isCreatingTrackExpense || isUnreported ? policyForMovingExpensesID : getIOURequestPolicyID(transaction, report);

Root cause was useOnyx caching logic assuming the subscribed key never changes (or only within same collection). When withWritableReportOrNotFound swapped route.params.reportID, our wrapper enabled allowDynamicKey so the hook reused the same connection but never marked the snapshot stale. getSnapshot() therefore kept returning the previous key’s cached value

What changes do you think we should make in order to solve the problem?

We can store the last key, and when a new key arrives we mark the snapshot as stale, reset the previous value, and emit a transitional loading state so the next getSnapshot() pull reads the correct cache entry instead of reusing the prior key’s data

const lastConnectedKeyRef = useRef<TKey>(key);
useEffect(() => {
        if (lastConnectedKeyRef.current === key) {
            return;
        }
        lastConnectedKeyRef.current = key;
        shouldGetCachedValueRef.current = true;
        previousValueRef.current = null;
        resultRef.current = [
            undefined,
            {status: options?.initWithStoredValues === false ? 'loaded' : 'loading'},
        ];
    }, [key, options?.initWithStoredValues]);

https://github.com/Expensify/react-native-onyx/blob/04f78bd2a6c86374d4b19fd4bc09cba003ee0477/lib/useOnyx.ts#L72

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!