Merge pull request #58 from Evref-BL/develop

Gitlab-Pharo-API 1.0.2

Author: knowbased

src/GitlabAPI-Branches-Tests/GitlabBranchesTest.class.st

@@ -11,54 +11,65 @@ Class {
 { #category : 'tests' }
 GitlabBranchesTest >> testCreateInProjectFromRef [
 
-	| hostUrl gitlabApi branchName projectId ref result client postMessage|
-	
+	| hostUrl gitlabApi branchName projectId ref result client postMessage |
 	"Given"
 	hostUrl := 'www.url.com'.
 	client := ZnClient new.
 	postMessage := 'success'.
-	
-	client stub post willReturn:  '{"message": "', postMessage, '"}'.
-	gitlabApi := GitlabApi new privateToken: 'token'; hostUrl: hostUrl; client: client.
-	
+
+	client stub post willReturn: '{"message": "' , postMessage , '"}'.
+	gitlabApi := GitlabApi new
+		             privateToken: 'token';
+		             hostUrl: hostUrl;
+		             client: client.
+
 	branchName := 'test'.
 	projectId := 1.
 	ref := 'main'.
-	
+
 	"When"
-	result := gitlabApi branches create: branchName inProject: projectId fromRef: ref.
-	
+	result := gitlabApi branches
+		          create: branchName
+		          inProject: projectId
+		          fromRef: ref.
+
 	"Then"
 	(client request url query at: #branch) should be: branchName.
 	(client request url query at: #ref) should be: ref.
 	self assert: (result at: #message) equals: postMessage
-
 ]
 
 { #category : 'tests' }
 GitlabBranchesTest >> testGetAllFromProject [
 
 	| hostUrl gitlabApi projectId result client branch1 branch2 gitlabBranches endpoint |
-	
 	"Given"
 	hostUrl := 'www.url.com'.
 	client := Mock new.
-	
-	gitlabApi := GitlabApi new privateToken: 'token'; hostUrl: hostUrl; client: client; output: 'json'.
-	
+
+	gitlabApi := GitlabApi new
+		             privateToken: 'token';
+		             hostUrl: hostUrl;
+		             client: client;
+		             output: 'json'.
+
 	gitlabBranches := GitlabBranches new gitlabAPI: gitlabApi.
-	
+
 	branch1 := '{"name": "branch1"}'.
 	branch2 := '{"name": "branch2"}'.
 	projectId := 1.
-	
-	endpoint := '/projects/', projectId asString, '/repository/branches'.
-	(gitlabBranches stub getAll: endpoint withParams: Dictionary new) willReturn: { branch1. branch2 }. 
-	
+
+	endpoint := '/projects/' , projectId asString
+	            , '/repository/branches'.
+	(gitlabBranches stub getAll: endpoint withParams: Dictionary new)
+		willReturn: {
+				branch1.
+				branch2 }.
+
 	"When"
 	result := gitlabBranches getAllFromProject: projectId.
-	
+
 	"Then"
 	self assert: result size equals: 2.
-	self assert: (result first) equals: branch1.
+	self assert: result first equals: branch1
 ]

src/GitlabAPI-Branches/GitlabBranches.class.st

@@ -11,19 +11,22 @@ GitlabBranches >> create: name inProject: projectId fromRef: ref [
 
 	| response |
 	gitlabAPI client url:
-		gitlabAPI hostUrl , '/projects/' , projectId asString , '/repository/branches'.
+		gitlabAPI hostUrl , '/projects/' , projectId asString
+		, '/repository/branches'.
 	gitlabAPI client queryAt: #branch put: name.
 	gitlabAPI client queryAt: #ref put: ref.
 	response := gitlabAPI client post.
-	
-	^NeoJSONReader fromString: response.
+
+	^ NeoJSONReader fromString: response
 ]
 
 { #category : 'api' }
 GitlabBranches >> getAllFromProject: projectId [
-	"https://docs.gitlab.com/ee/api/branches.html#list-repository-branches"	
+	"https://docs.gitlab.com/ee/api/branches.html#list-repository-branches"
+
 	| endpoint |
-	endpoint := '/projects/', projectId asString, '/repository/branches'.
-		
-	^self getAll: endpoint withParams: Dictionary new.
+	endpoint := '/projects/' , projectId asString
+	            , '/repository/branches'.
+
+	^ self getAll: endpoint withParams: Dictionary new
 ]

src/GitlabAPI-Commits-Tests/GitlabActionTest.class.st

@@ -10,41 +10,44 @@ Class {
 
 { #category : 'tests' }
 GitlabActionTest >> testAsDictionary [
-
 	"Given"
+
 	| action filePath content gitlabAction dict |
 	action := 'update'.
 	filePath := 'file.txt'.
 	content := 'content'.
-	
-	gitlabAction := GitlabAction new action: action; content: content; filePath: filePath.
-	
+
+	gitlabAction := GitlabAction new
+		                action: action;
+		                content: content;
+		                filePath: filePath.
+
 	"When"
 	dict := gitlabAction asDictionary.
-	
+
 	"Then"
 	self assert: (dict at: #action) equals: action.
 	self assert: (dict at: #file_path) equals: filePath.
-	self assert: (dict at: #content) equals: content.
-	 
+	self assert: (dict at: #content) equals: content
 ]
 
 { #category : 'tests' }
 GitlabActionTest >> testAsDictionaryWithoutParams [
-
 	"Given"
+
 	| action filePath gitlabAction dict |
 	action := 'update'.
 	filePath := 'file.txt'.
-	
-	gitlabAction := GitlabAction new action: action; filePath: filePath.
-	
+
+	gitlabAction := GitlabAction new
+		                action: action;
+		                filePath: filePath.
+
 	"When"
 	dict := gitlabAction asDictionary.
-	
+
 	"Then"
 	self assert: (dict at: #action) equals: action.
 	self assert: (dict at: #file_path) equals: filePath.
-	self assert: (dict includesKey: #content) equals: false.
-	 
+	self assert: (dict includesKey: #content) equals: false
 ]