Fix player commands option not working (#6214)

Fixes regression from 8d44d1a

Author: JRoy

Essentials/src/main/java/com/earth2me/essentials/metrics/MetricsWrapper.java

@@ -52,7 +52,8 @@ private void addPermsChart() {
             final Map<String, Map<String, Integer>> result = new HashMap<>();
             final String handler = ess.getPermissionsHandler().getName();
             final Map<String, Integer> backend = new HashMap<>();
-            backend.put(ess.getPermissionsHandler().getBackendName(), 1);
+            final String backendName = ess.getPermissionsHandler().getBackendName();
+            backend.put(backendName != null ? backendName : "Other", 1);
             result.put(handler, backend);
             return result;
         }));

Essentials/src/main/java/com/earth2me/essentials/perm/PermissionsHandler.java

@@ -198,6 +198,9 @@ public void checkPermissions() {
             String enabledPermsPlugin = ((AbstractVaultHandler) handler).getEnabledPermsPlugin();
             if (enabledPermsPlugin == null) enabledPermsPlugin = "generic";
             ess.getLogger().info("Using Vault based permissions (" + enabledPermsPlugin + ")");
+        } else if (handler.getClass() == ConfigPermissionsHandler.class) {
+            ess.getLogger().info("Using config file enhanced permissions.");
+            ess.getLogger().info("Permissions listed in as player-commands will be given to all users.");
         } else if (handler.getClass() == SuperpermsHandler.class) {
             if (handler.tryProvider(ess)) {
                 ess.getLogger().warning("Detected supported permissions plugin " +
@@ -206,9 +209,6 @@ public void checkPermissions() {
                     "work until you install Vault.");
             }
             ess.getLogger().info("Using superperms-based permissions.");
-        } else if (handler.getClass() == ConfigPermissionsHandler.class) {
-            ess.getLogger().info("Using config file enhanced permissions.");
-            ess.getLogger().info("Permissions listed in as player-commands will be given to all users.");
         }
     }
 

Essentials/src/main/java/com/earth2me/essentials/perm/impl/SuperpermsHandler.java

@@ -171,10 +171,6 @@ public String getEnabledPermsPlugin() {
             }
         }
 
-        if (enabledPermsPlugin == null) {
-            enabledPermsPlugin = "Other";
-        }
-
         return enabledPermsPlugin;
     }
 }