Test against configured host rather than request host

Author: fbacall

app/controllers/callbacks_controller.rb

@@ -45,7 +45,7 @@ def handle_callback(provider, config)
   private
 
   def redirect_to_space(path, space)
-    if space && space.is_subdomain?(request.domain)
+    if space&.is_subdomain?
       port_part = ''
       port_part = ":#{request.port}" if (request.protocol == "http://" && request.port != 80) ||
                                         (request.protocol == "https://" && request.port != 443)

app/models/space.rb

@@ -65,7 +65,7 @@ def enabled_features
     (FEATURES - disabled_features)
   end
 
-  def is_subdomain?(domain)
+  def is_subdomain?(domain = TeSS::Config.base_uri.domain)
     (host == domain || host.ends_with?(".#{domain}"))
   end
 

test/models/space_test.rb

@@ -129,11 +129,13 @@ class SpaceTest < ActiveSupport::TestCase
     assert_equal [], @space.disabled_features
   end
 
-  test 'check subdomain of' do
+  test 'is_subdomain?' do
     assert @space.is_subdomain?('mytess.training')
     refute @space.is_subdomain?('amytess.training')
     refute @space.is_subdomain?('mytess.com')
     refute @space.is_subdomain?('mytess.training.com')
     refute @space.is_subdomain?('space.mytess.training')
+    refute @space.is_subdomain?
+    assert Space.new(host: 'test.example.com').is_subdomain?
   end
 end