-
Notifications
You must be signed in to change notification settings - Fork 8
Description
[issue copied from cc-plugin-cc6]
I think there's an issue in the longitude check because two checks are contradicting when applied to the AUS domain which crosses the 180/-180 line. (See image in https://github.com/WCRP-CORDEX/domain-tables/).
I am referring to check CDXV003.
- If longitude values are [0, 360], this fails with :
Longitude values are required to take the smallest absolute value in the range [-180, 360], as any values east of 180° could be negative instead. - If longitude values are [-180, 180], this fails with:
The longitude coordinate should be strictly monotonically increasing., as there a leap from 180 to -180 in the middle.
Moreover, the current cmor tables seem to define the valid range as [0, 360].
https://github.com/WCRP-CORDEX/cordex-cmip6-cmor-tables/blob/50af478ebb019d9358b1c87d02236150b06fb3b0/Tables/CORDEX-CMIP6_coordinate.json#L225-L226
My guess is that the CMOR definition is inherited from GCMs and the test implemented in cc-plugins-cc6 and here did not take all domains into account.
I would argue that in this case, the [0, 360] range is much more appropriate, and the other check could be ignored. However, even with this change, the ARC and ANT domains wouldn't be able to respect the "monotonicaly increasing" condition. Does this mean we should have exceptions for those, or that the full check should have a lower severity ?
As a side note, I am not managing any AUS data. I stumbled on this problem with NAM data, but our actual domain crosses the antimeridian somewhere in Russia.