fix: match find_info by name AND author to prevent duplicates

The find_info method was only matching by name, which was inconsistent
with the rest of the codebase (info_array deduplication, find_by_type).
This caused incorrect deletion logic when mods/tools had the same name
but different authors, leading to duplicate entries in the database.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: dyoung522

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 ## History (reverse chronological order)
 
+### v2.5.3 - 2026-03-04
+
+- Fix `find_info` to match by both name AND author, not just name
+  - Previously, mods/tools with the same name but different authors could cause incorrect deletion logic
+  - Now consistent with `info_array` deduplication and `find_by_type` lookups
+
 ### v2.5.2 - 2026-02-09
 
 - Fix duplicate entries created during sync operations

lib/icarus/mod/tools/sync/mods.rb

@@ -36,7 +36,7 @@ def find(modinfo)
           end
 
           def find_info(modinfo)
-            @info_array.find { |mod| mod.name == modinfo.name }
+            @info_array.find { |mod| mod.name == modinfo.name && mod.author == modinfo.author }
           end
 
           def update(modinfo)

lib/icarus/mod/tools/sync/tools.rb

@@ -38,7 +38,7 @@ def find(toolinfo)
           end
 
           def find_info(toolinfo)
-            @info_array.find { |tool| tool.name == toolinfo.name }
+            @info_array.find { |tool| tool.name == toolinfo.name && tool.author == toolinfo.author }
           end
 
           def update(toolinfo)

lib/icarus/mod/version.rb

@@ -2,6 +2,6 @@
 
 module Icarus
   module Mod
-    VERSION = "2.5.2"
+    VERSION = "2.5.3"
   end
 end

spec/icarus/mod/tools/sync/mods_spec.rb

@@ -95,10 +95,30 @@
     end
   end
 
-  describe "#find_modinfo" do
+  describe "#find_info" do
     it "returns a Modinfo object" do
       expect(modsync.find_info(modinfo)).to be_a(Icarus::Mod::Tools::Modinfo)
     end
+
+    context "when mods have the same name but different authors" do
+      let(:mod_author1) { Icarus::Mod::Tools::Modinfo.new({ name: "SharedName", author: "Author1", description: "Test" }) }
+      let(:mod_author2) { Icarus::Mod::Tools::Modinfo.new({ name: "SharedName", author: "Author2", description: "Test" }) }
+      let(:search_for_author2) { Icarus::Mod::Tools::Modinfo.new({ name: "SharedName", author: "Author2", description: "Test" }) }
+
+      before do
+        modsync.instance_variable_set(:@info_array, [mod_author1, mod_author2])
+      end
+
+      it "matches by both name AND author, not just name" do
+        result = modsync.find_info(search_for_author2)
+        expect(result.author).to eq("Author2")
+      end
+
+      it "returns nil when author does not match" do
+        nonexistent = Icarus::Mod::Tools::Modinfo.new({ name: "SharedName", author: "Author3", description: "Test" })
+        expect(modsync.find_info(nonexistent)).to be_nil
+      end
+    end
   end
 
   describe "#update" do

spec/icarus/mod/tools/sync/tools_spec.rb

@@ -99,6 +99,26 @@
     it "returns a Toolinfo object" do
       expect(toolsync.find_info(toolinfo)).to be_a(Icarus::Mod::Tools::Toolinfo)
     end
+
+    context "when tools have the same name but different authors" do
+      let(:tool_author1) { Icarus::Mod::Tools::Toolinfo.new({ name: "SharedName", author: "Author1", description: "Test" }) }
+      let(:tool_author2) { Icarus::Mod::Tools::Toolinfo.new({ name: "SharedName", author: "Author2", description: "Test" }) }
+      let(:search_for_author2) { Icarus::Mod::Tools::Toolinfo.new({ name: "SharedName", author: "Author2", description: "Test" }) }
+
+      before do
+        toolsync.instance_variable_set(:@info_array, [tool_author1, tool_author2])
+      end
+
+      it "matches by both name AND author, not just name" do
+        result = toolsync.find_info(search_for_author2)
+        expect(result.author).to eq("Author2")
+      end
+
+      it "returns nil when author does not match" do
+        nonexistent = Icarus::Mod::Tools::Toolinfo.new({ name: "SharedName", author: "Author3", description: "Test" })
+        expect(toolsync.find_info(nonexistent)).to be_nil
+      end
+    end
   end
 
   describe "#update" do