Skip to content

Commit c895ac2

Browse files
committed
feat: Connect Github-flavored markdown to timeline events
Signed-off-by: Jared Scott <jared.scott@datarecce.io>
1 parent 809cb78 commit c895ac2

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

js/src/components/check/timeline/TimelineEvent.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import {
3636
PiPlusCircle,
3737
PiTrashSimple,
3838
} from "react-icons/pi";
39+
import { MarkdownContent } from "@/components/ui/markdown/MarkdownContent";
3940
import { Tooltip } from "@/components/ui/tooltip";
4041
import { CheckEvent, getEventIconType } from "@/lib/api/checkEvents";
4142
import { fetchGitHubAvatar } from "@/lib/api/user";
@@ -315,9 +316,7 @@ function CommentEvent({
315316
borderColor="gray.200"
316317
position="relative"
317318
>
318-
<Text fontSize="sm" whiteSpace="pre-wrap">
319-
{event.content}
320-
</Text>
319+
<MarkdownContent content={event.content || ""} fontSize="sm" />
321320

322321
{/* Edit/Delete buttons - only visible to author on hover */}
323322
<Activity

js/src/components/ui/markdown/MarkdownContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function MarkdownLink({
9999
color="blue.500"
100100
textDecoration="underline"
101101
_hover={{ color: "blue.600" }}
102-
target={isExternal ? "_blank" : undefined}
102+
target="_blank"
103103
rel={isExternal ? "noopener noreferrer" : undefined}
104104
>
105105
{children}

0 commit comments

Comments
 (0)