Merge pull request #50 from DSACMS/DSACMS/nat/pr-check-fixes

Frontend: Fix PR checks and add privacy policy

Author: natalialuzuriaga

_data/codegovData.js

@@ -87,8 +87,8 @@ module.exports = function() {
             agencies.push({
                 code: agencyName,
                 name: agencyName,
-                version: "1.0.0",
-                measurementType: "Projects",
+                version: '1.0.0',
+                measurementType: 'Projects',
                 organizations: agencyOrgs,
                 projectCount: releases.length,
                 totalLaborHours: releases.reduce((acc, curr) => acc + (curr.laborHours  || 0), 0)
@@ -112,7 +112,7 @@ module.exports = function() {
 
             projects.push({
                 agencyCode: agencyName,
-                agencyName: agencyName,
+                agencyName,
                 organization: release.organization,
                 name: release.name,
                 description: release.description,

assets/_common/js/filters.js

@@ -30,8 +30,7 @@ const applySearchFilter = (data, searchTerm, targetType) => {
     });
 };
 
-const applySelectFilters = (data, filters, targetType) => {
-    return Object.entries(filters).reduce((filtered, [key, value]) => {
+const applySelectFilters = (data, filters, targetType) => Object.entries(filters).reduce((filtered, [key, value]) => {
         if (!value || key === 'search') return filtered;
 
         return filtered.filter(item => {
@@ -80,13 +79,12 @@ const applySelectFilters = (data, filters, targetType) => {
             }
         });
     }, data);
-};
 
 const sortData = (data, sortBy) => {
     const [field, direction] = sortBy.split('-');
 
     return [...data].sort((a, b) => {
-        let aVal, bVal;
+        let aVal; let bVal;
 
         switch (field) {
             case 'name':

assets/_common/js/issue-filters.js

@@ -34,8 +34,7 @@ const applySearchFilter = (data, searchTerm) => {
   });
 };
 
-const applySelectFilters = (data, filters) => {
-  return Object.entries(filters).reduce((filtered, [key, value]) => {
+const applySelectFilters = (data, filters) => Object.entries(filters).reduce((filtered, [key, value]) => {
       if (!value || key === 'search') return filtered;
 
       return filtered.filter(issue => {
@@ -58,13 +57,12 @@ const applySelectFilters = (data, filters) => {
           }
       });
   }, data);
-};
 
 const sortData = (data, sortBy) => {
   const [field, direction] = sortBy.split('-');
 
   return [...data].sort((a, b) => {
-      let aVal, bVal;
+      let aVal; let bVal;
 
       switch (field) {
           case 'created':
@@ -294,8 +292,7 @@ const bindEvents = (state, setState) => {
   }
 };
 
-const preprocessIssuesData = (issues) => {
-  return issues.map(issue => {
+const preprocessIssuesData = (issues) => issues.map(issue => {
       // Extract repo name from URL
       if (issue.url) {
           const urlParts = issue.url.split('/');
@@ -310,7 +307,6 @@ const preprocessIssuesData = (issues) => {
 
       return issue;
   });
-};
 
 const initializeIssueFilters = (data) => {
   const processedData = preprocessIssuesData(data);

config/updateCodeGov.js

@@ -1,10 +1,10 @@
-const fs = require("fs").promises
+const fs = require('fs').promises
 const path = require('path')
 
 // these will always stay constant
 const CONFIG = {
-  agencyDirectory: path.resolve(__dirname, "../agency-indexes"),
-  outputFile: path.resolve(__dirname, "../codegov.json"),
+  agencyDirectory: path.resolve(__dirname, '../agency-indexes'),
+  outputFile: path.resolve(__dirname, '../codegov.json'),
   regex: /^(.*?)-.*\.json$/  
 }
 
@@ -25,7 +25,7 @@ async function updateCodeGov() {
       const filePath = path.join(CONFIG.agencyDirectory, file)
 
       try {
-        const content = await fs.readFile(filePath, "utf-8")
+        const content = await fs.readFile(filePath, 'utf-8')
         const jsonData = JSON.parse(content)
 
         // store the agency name only for readability in codegov.json 
@@ -45,7 +45,7 @@ async function updateCodeGov() {
 
     return updatedJSON
   } catch (error) {
-    console.error("❌ Failed to update codegov.json:", error)
+    console.error('❌ Failed to update codegov.json:', error)
   }
 }
 

config/updateIssuePool.js

@@ -1,9 +1,9 @@
-const fs = require("fs").promises
+const fs = require('fs').promises
 const path = require('path')
 
 const CONFIG = {
-    repoFilePath: path.resolve(__dirname, "../codegov.json"),
-    issueFilePath: path.resolve(__dirname, "../issue-pool.json"),
+    repoFilePath: path.resolve(__dirname, '../codegov.json'),
+    issueFilePath: path.resolve(__dirname, '../issue-pool.json'),
     regex: /https?:\/\/github\.com\/([^\/]+)\/([^\/]+)/,
     githubToken: process.env.GITHUB_TOKEN,
     requiredLabel: 'code-gov',
@@ -41,10 +41,10 @@ async function fetchWithRateLimit(url, options = {}) {
 }
 
 async function getRepoInfo() { // dont know how i feel about this double loop setup...
-    let repoInfo = []
+    const repoInfo = []
 
     try {
-        const content = await fs.readFile(CONFIG.repoFilePath, "utf-8") 
+        const content = await fs.readFile(CONFIG.repoFilePath, 'utf-8') 
         const jsonData = JSON.parse(content)
 
         for (const agencyKey in jsonData) {
@@ -71,7 +71,7 @@ async function getRepoInfo() { // dont know how i feel about this double loop se
             }
         }
     } catch (error) {
-        console.error("Error in getting repo information:", error)
+        console.error('Error in getting repo information:', error)
     }
 
     // console.log(repoInfo)
@@ -102,11 +102,11 @@ function transformIssue(issue, repo, repoLanguage) {
         id: String(issue.id),
         number: issue.number,
         url: issue.html_url,
-        content_title: issue.title || "",
-        content_description: issue.body || "",
+        content_title: issue.title || '',
+        content_description: issue.body || '',
         repo_name: repo.repoName,
         repo_url: `https://github.com/${repo.ownerName}/${repo.repoName}`,
-        repo_language: repoLanguage || "",
+        repo_language: repoLanguage || '',
         repo_owner: repo.ownerName,
         status_is_open: issue.state === 'open',
         status_has_assignee: issue.assignee !== null,
@@ -115,9 +115,9 @@ function transformIssue(issue, repo, repoLanguage) {
         time_last_updated: issue.updated_at,
         time_days_old: daysBetween(createdDate, now),
         time_last_activity_days_ago: daysBetween(updatedDate, now),
-        people_author: issue.user?.login || "",
+        people_author: issue.user?.login || '',
         people_assignee: issue.assignee?.login || null,
-        people_author_type: issue.user?.type || "",
+        people_author_type: issue.user?.type || '',
         labels_list: labelNames,
         labels_count: labelNames.length,
         labels_has_priority: checkLabelKeywords(issue.labels, ['priority', 'p0', 'p1', 'p2', 'urgent']),
@@ -146,7 +146,7 @@ async function processSingleRepository(repo, headers) {
         }
 
         const repoData = await repoResponse.json()
-        const repoLanguage = repoData.language || ""
+        const repoLanguage = repoData.language || ''
 
         let page = 1
         let hasMore = true
@@ -215,9 +215,9 @@ async function updateIssuePool() {
 
     try {
         await fs.writeFile(CONFIG.issueFilePath, JSON.stringify(issuePool, null, 2))
-        console.log(`Successfully saved issues!`)
+        console.log('Successfully saved issues!')
     } catch (error) {
-        console.error("Error saving issue pool:", error)
+        console.error('Error saving issue pool:', error)
     }
 
     return issuePool

content/privacy-policy/index.md

@@ -0,0 +1,16 @@
+---
+title: Privacy Policy
+description: 'Privacy Policy'
+permalink: /privacy-policy/
+layout: layouts/page
+tags: codegov
+eleventyNavigation:
+  parent: codegov-privacypolicy
+  key: codegov-privacypolicy-main
+  order: 1
+  title: Privacy Policy
+sidenav: false
+sticky_sidenav: false
+---
+
+This website follows the [HHS Privacy Policy](https://www.hhs.gov/web/policies-and-standards/hhs-web-policies/privacy/index.html).

index.html

@@ -34,20 +34,20 @@ <h2>Developers</h2>
             href="https://github.com/GSA/code-gov/blob/master/README.md" target="_blank">contribute here</a>. Help
           improve America's Code by exploring projects.
         </p>
-        <a class="usa-button" href="{{'/projects' | url }}">Explore projects</a>
+        <a class="usa-button" href="{{'/projects/' | url }}">Explore projects</a>
       </div>
       <div class="explore-inventory">
         <h2>Source Code Inventory</h2>
         <p>Review source code development across the entire federal government.</p>
-        <a class="usa-button" href="{{'/agencies' | url }}"> View by Agency </a>
+        <a class="usa-button" href="{{'/agencies/' | url }}"> View by Agency </a>
       </div>
       <div class="explore-agencies">
         <h2>Agency Partners</h2>
         <p>
           Federal agency partners use Code.gov to share usable open source code, promote open source
           projects, and track compliance with federal open source policy.
         </p>
-        <a class="usa-button" href="{{'/agency-compliance/compliance/dashboard' | url }}">Agency Compliance</a>
+        <a class="usa-button" href="{{'/agency-compliance/compliance/dashboard/' | url }}">Agency Compliance</a>
       </div>
     </div>
     <div class="grid-row">
@@ -108,7 +108,7 @@ <h3>OPT-IN WITH LABELS</h3>
             </div>
           </div>
           <div style="text-align: center; margin-top: 2rem;">
-            <a class="usa-button" href="/code-gov/issues/">Browse Issues</a>
+            <a class="usa-button" href="{{'/issues/' | url }}">Browse Issues</a>
           </div>
         </div>
       </section>