Add support for Visual Studio 2026 by hwangsihu · Pull Request #2509 · DOCGroup/ACE_TAO

hwangsihu · 2026-03-04T09:42:15Z

Summary by CodeRabbit

New Features
- Added support for Visual Studio 2026, including updated compiler/toolset and project templates for VS2026.
Chores
- Updated CI workflows to include Windows builds using Visual Studio 2026.
Documentation
- Added a NEWS entry announcing Visual Studio 2026 support.

coderabbitai · 2026-03-04T09:42:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 18f06677-5807-4668-8f2a-ebf97a1c83da

📥 Commits

Reviewing files that changed from the base of the PR and between fcf88ad and a0b4738.

📒 Files selected for processing (1)

.github/workflows/windows.yml

Walkthrough

Added Visual Studio 2026 support: CI workflow matrix entries, a new MSVC 14.5 config header, updated MSVC version gating, VS2026 build feature and nmake config files, and a NEWS entry documenting the addition.

Changes

Cohort / File(s)	Summary
CI Workflows `\.github/workflows/cmake.yml`, `\.github/workflows/windows.yml`	Added VS2026 matrix entries targeting `windows-2025-vs2026` runner with `vs2026` toolset and x64 Debug/Release variants; mirrors existing VS entries.
MSVC Configuration `ACE/ace/config-win32-msvc-145.h`, `ACE/ace/config-win32-msvc.h`	Added new MSVC 14.5 config header defining `ACE_WIN32_VC145`; updated `_MSC_VER` gating in `config-win32-msvc.h` to include the new header when `_MSC_VER >= 1950`.
Build System Configuration `ACE/bin/MakeProjectCreator/config/vs2026.features`, `ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb`	New VS2026 feature file (ssl=0, qos=1, rwho=0, sctp=0) and nmake config disabling `/Wp64` and `/Gm` and suppressing VC warnings 4456/4458/4459 for nmake backend.
Documentation `ACE/NEWS`	Added an entry noting Visual Studio 2026 support.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Reworked disabling error windows by introducing new defines so that we can more eas… #2352: Changes to ACE/ace/config-win32-msvc.h that overlap with MSVC version gating and configuration header organization.
Updates for Visual C++ CI and C++20 compatibility #2390: Updates to GitHub Actions Windows/Visual Studio workflow files similar to the CI matrix changes here.

Poem

🐰 Hop! VS2026 hops into sight,
New configs snug, compiled just right.
Workflows hum and feature files sing,
Nmake trims flags—what joy they bring!
ACE and I nibble code with delight.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add support for Visual Studio 2026' clearly and directly summarizes the main change across all modified files, which consistently add VS 2026 configuration support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jwillemsen · 2026-03-04T09:57:47Z

Have you done a full build with tests? On github CI we only compile a small part of the code and don't run tests at all.

hwangsihu · 2026-03-04T10:29:42Z

Hi.

Sorry, is there any documentation on building ACE and TAO? I can't find it.

jwillemsen · 2026-03-04T10:34:50Z

See https://htmlpreview.github.io/?https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/ACE-INSTALL.html, at the bottom there are some instructions to build from git. Without a full build/test I think it is too early to say Visual Studio 2026 is supported, maybe it compiles the core, but the real test is a full build/test and also look at warnings and runtime test results.

jwillemsen · 2026-03-04T13:54:29Z

Depends on DOCGroup/MPC#242

hwangsihu · 2026-03-04T15:24:25Z

Okay, Seems good.

jwillemsen · 2026-03-05T08:39:40Z

ACE/bin/MakeProjectCreator/config/acedefaults.mpb

 feature(ace_languagestandard2017) {
-  specific(vs2017,vs2019,vs2022) {
+  specific(vs2017,vs2019,vs2022,vs2026) {
    LanguageStandard = stdcpp17


Don't think vs2026 needs this overwritten standard version

CI tests in DOCGroup/MPC#242 failed because this option was missing. Will merging the PR with this option removed solve the problem?

The default C++ version for Visual Studio 2026 is C++20 as far as I can determine from public documentation, so something to investigate and test more.

jwillemsen · 2026-03-05T08:40:00Z

ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb

+
+feature(ace_languagestandard2017) {
+  specific(nmake) {
+    compile_flags += /std:c++17


think this feature is not necessary

ACE/tests/OneByteFile

Add support for Visual Studio 2026

a84d969

hwangsihu marked this pull request as draft March 4, 2026 10:37

hwangsihu marked this pull request as ready for review March 4, 2026 15:24

jwillemsen reviewed Mar 5, 2026

View reviewed changes

jwillemsen reviewed Mar 6, 2026

View reviewed changes

ACE/tests/OneByteFile Outdated Show resolved Hide resolved

Remove C++17 language standard override for vs2026

fcf88ad

hwangsihu force-pushed the master branch from 0e30fbf to fcf88ad Compare March 6, 2026 13:06

Merge branch 'master' into master

a0b4738

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Visual Studio 2026#2509

Add support for Visual Studio 2026#2509
hwangsihu wants to merge 3 commits intoDOCGroup:masterfrom
hwangsihu:master

hwangsihu commented Mar 4, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

hwangsihu Mar 5, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

hwangsihu commented Mar 4, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwangsihu Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

hwangsihu commented Mar 4, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 4, 2026 •

edited

Loading