Skip to content

Commit d24e733

Browse files
committed
fix(ci): fallback to vars for submit credentials
- Resolve missing required config in submit workflow when values are stored in GitHub Variables instead of Secrets - Keep existing secrets first and add vars fallback for Chrome, Firefox, and Edge credentials
1 parent 5e86131 commit d24e733

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

.github/workflows/submit.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,16 @@ jobs:
4040
run: pnpm zip:firefox
4141
- name: Submit to web stores
4242
env:
43-
CHROME_EXTENSION_ID: ${{ secrets.CHROME_EXTENSION_ID }}
44-
CHROME_CLIENT_ID: ${{ secrets.CHROME_CLIENT_ID }}
45-
CHROME_CLIENT_SECRET: ${{ secrets.CHROME_CLIENT_SECRET }}
46-
CHROME_REFRESH_TOKEN: ${{ secrets.CHROME_REFRESH_TOKEN }}
47-
FIREFOX_EXTENSION_ID: ${{ secrets.FIREFOX_EXTENSION_ID }}
48-
FIREFOX_JWT_ISSUER: ${{ secrets.FIREFOX_JWT_ISSUER }}
49-
FIREFOX_JWT_SECRET: ${{ secrets.FIREFOX_JWT_SECRET }}
50-
EDGE_PRODUCT_ID: ${{ secrets.EDGE_PRODUCT_ID }}
51-
EDGE_CLIENT_ID: ${{ secrets.EDGE_CLIENT_ID }}
52-
EDGE_API_KEY: ${{ secrets.EDGE_API_KEY }}
43+
CHROME_EXTENSION_ID: ${{ secrets.CHROME_EXTENSION_ID || vars.CHROME_EXTENSION_ID }}
44+
CHROME_CLIENT_ID: ${{ secrets.CHROME_CLIENT_ID || vars.CHROME_CLIENT_ID }}
45+
CHROME_CLIENT_SECRET: ${{ secrets.CHROME_CLIENT_SECRET || vars.CHROME_CLIENT_SECRET }}
46+
CHROME_REFRESH_TOKEN: ${{ secrets.CHROME_REFRESH_TOKEN || vars.CHROME_REFRESH_TOKEN }}
47+
FIREFOX_EXTENSION_ID: ${{ secrets.FIREFOX_EXTENSION_ID || vars.FIREFOX_EXTENSION_ID }}
48+
FIREFOX_JWT_ISSUER: ${{ secrets.FIREFOX_JWT_ISSUER || vars.FIREFOX_JWT_ISSUER }}
49+
FIREFOX_JWT_SECRET: ${{ secrets.FIREFOX_JWT_SECRET || vars.FIREFOX_JWT_SECRET }}
50+
EDGE_PRODUCT_ID: ${{ secrets.EDGE_PRODUCT_ID || vars.EDGE_PRODUCT_ID }}
51+
EDGE_CLIENT_ID: ${{ secrets.EDGE_CLIENT_ID || vars.EDGE_CLIENT_ID }}
52+
EDGE_API_KEY: ${{ secrets.EDGE_API_KEY || vars.EDGE_API_KEY }}
5353
run: |
5454
DRY_RUN_FLAG=""
5555
if [ "${{ inputs.dry_run }}" = "true" ]; then

0 commit comments

Comments
 (0)