-
Notifications
You must be signed in to change notification settings - Fork 545
perf(Mux): shared selector decomposition and ±Y symmetry optimization in emulated MSM #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b96d585
perf(Mux): share binary decomposition across limbs
yelhousni 353d925
perf(msm): ±Y symmetry so to use 8-to-1 Mux instead of 16-to-1
yelhousni 68206e5
perf(mux): constant selector + n=2 + skip redundant boolean assertion
yelhousni d838342
test: up stats
yelhousni 2b54dd0
refactor: clean code
yelhousni 80e4c46
Merge branch 'master' into perf/mux
yelhousni 663386d
fix(mux): add edge case handling for nbInputs == 1
yelhousni edd5f17
Merge branch 'master' into perf/mux
yelhousni 3639dc0
Merge branch 'master' into perf/mux
yelhousni 72227de
refactor: remove BinaryMuxUnchecked and GeneralMuxUnchecked
yelhousni 9eba900
refactor: replace cmp.NewBoundedComparator with a MustBeLessOrEqCst
yelhousni 5ead7d7
style: slice expansion syntax
yelhousni 6d19909
style: naming changes
yelhousni c140252
Merge branch 'master' into perf/mux
yelhousni 5b9799e
Merge branch 'perf/mux' of github.com:consensys/gnark into perf/mux
yelhousni de2cef3
fix: revert to raw int(0)
yelhousni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.