Skip to content

Update evaporation relaxation#710

Merged
trontrytel merged 1 commit intomainfrom
oa/change_evap
Apr 9, 2026
Merged

Update evaporation relaxation#710
trontrytel merged 1 commit intomainfrom
oa/change_evap

Conversation

@oalcabes
Copy link
Copy Markdown
Member

@oalcabes oalcabes commented Apr 3, 2026

This PR changes the evaporation and sublimation tendencies to relax towards equilibrium, rather than towards zero condensate.

@oalcabes oalcabes added the NonEq 💧🧊 Non equilibrium microphysics label Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (be6d8df) to head (9541c56).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          54       54           
  Lines        2242     2242           
=======================================
  Hits         2063     2063           
  Misses        179      179           
Components Coverage Δ
src 93.01% <ø> (ø)
ext 69.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tendency = ifelse(
sat_excess < 0,
-max(FT(0), q_icl) / timescale,
-min(-sat_excess, max(0, q_lcl)) / timescale,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be q_icl

Copy link
Copy Markdown
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving to you what sort of release you want to make it be

@trontrytel trontrytel enabled auto-merge April 9, 2026 20:55
@trontrytel trontrytel merged commit 91a04fe into main Apr 9, 2026
16 of 17 checks passed
@trontrytel trontrytel deleted the oa/change_evap branch April 9, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved 🍀 NonEq 💧🧊 Non equilibrium microphysics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants