Skip to content

Try asking for less GPU time#697

Merged
trontrytel merged 1 commit intomainfrom
aj/slurm_time
Mar 12, 2026
Merged

Try asking for less GPU time#697
trontrytel merged 1 commit intomainfrom
aj/slurm_time

Conversation

@trontrytel
Copy link
Copy Markdown
Member

No description provided.

@trontrytel trontrytel self-assigned this Mar 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.98%. Comparing base (1a23646) to head (2960d29).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          53       53           
  Lines        2371     2371           
=======================================
  Hits         2252     2252           
  Misses        119      119           
Components Coverage Δ
src 96.04% <ø> (ø)
ext 69.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haakon-e haakon-e enabled auto-merge March 10, 2026 17:30
Copy link
Copy Markdown
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was a bit too quick in my review. It's probably best to apply the time limit to all jobs, the current state would only apply it to the init step.. As we discussed yesterday, the only risk this adds is if a long init step times out after clearing the shared depot.

Comment thread .buildkite/pipeline.yml
@trontrytel trontrytel disabled auto-merge March 10, 2026 19:01
@trontrytel trontrytel enabled auto-merge March 10, 2026 20:13
@trontrytel trontrytel merged commit e5cce6c into main Mar 12, 2026
12 checks passed
@trontrytel trontrytel deleted the aj/slurm_time branch March 12, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants