feat(es2): Only show non-cedar templates when adding metadata#1007
Open
adlius wants to merge 2 commits into
Open
feat(es2): Only show non-cedar templates when adding metadata#1007adlius wants to merge 2 commits into
adlius wants to merge 2 commits into
Conversation
nsemets
requested changes
Jun 8, 2026
| export class GetCedarMetadataTemplates { | ||
| static readonly type = '[Metadata] Get Cedar Metadata Templates'; | ||
| constructor(public url?: string) {} | ||
| constructor(public options: { url?: string } = {}) {} |
Collaborator
There was a problem hiding this comment.
Why did you change it to an object instead of using a string?
Contributor
Author
There was a problem hiding this comment.
I was planning on adding a filter here to filter for is_for_collection=false but then decided that filtering in memory is perhaps better. Do you want me to revert?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes