fix(meetings): fixed meetings small issues

Author: nsemets

src/app/features/meetings/components/meetings-feature-card/meetings-feature-card.component.spec.ts

@@ -13,7 +13,7 @@ describe('MeetingsFeatureCardComponent', () => {
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      imports: [MeetingsFeatureCardComponent, MockPipe(TranslatePipe, (value) => value)],
+      imports: [MeetingsFeatureCardComponent, MockPipe(TranslatePipe)],
     }).compileComponents();
 
     fixture = TestBed.createComponent(MeetingsFeatureCardComponent);

src/app/features/meetings/mappers/meetings.mapper.ts

@@ -31,7 +31,7 @@ export class MeetingsMapper {
         title: item.attributes.title,
         dateCreated: item.attributes.date_created,
         authorName: item.attributes.author_name,
-        downloadCount: item.attributes.download_count,
+        downloadCount: item.attributes.download_count || 0,
         meetingCategory: item.attributes.meeting_category,
         downloadLink: item.links.download,
       })),

src/app/features/meetings/models/meetings.models.ts

@@ -1,4 +1,4 @@
-import { NumberOrNull, StringOrNull } from '@osf/shared/helpers';
+import { StringOrNull } from '@osf/shared/helpers';
 
 export interface Meeting {
   id: string;
@@ -19,7 +19,7 @@ export interface MeetingSubmission {
   title: string;
   dateCreated: Date;
   authorName: string;
-  downloadCount: NumberOrNull;
+  downloadCount: number;
   meetingCategory: string;
   downloadLink: StringOrNull;
 }

src/app/features/meetings/pages/meeting-details/meeting-details.component.html

@@ -57,24 +57,24 @@
     </ng-template>
     <ng-template #body let-item>
       @if (item?.id) {
-        <tr class="cursor-pointer" [routerLink]="[item.id, 'overview']">
+        <tr class="cursor-pointer" [routerLink]="['/', item.id, 'overview']">
           <td>{{ item.title }}</td>
           <td>{{ item.authorName }}</td>
           <td>{{ item.meetingCategory }}</td>
           <td class="w-14rem">{{ item.dateCreated | date: 'MMM d, y, h:mm a' }}</td>
           <td class="text-center" [class.w-9rem]="!item.downloadCount">
-            @if (item.downloadCount) {
+            @if (item.downloadLink) {
               <p-button
                 [label]="'meetings.details.downloadButton' | translate"
-                icon="pi pi-download"
+                icon="fas fa-download"
                 class="mr-1"
                 severity="secondary"
                 [raised]="true"
                 (click)="downloadSubmission($event, item)"
               />
-              {{ item.downloadCount }}
+              <span class="ml-2">{{ item.downloadCount }}</span>
             } @else {
-              -
+              <span>-</span>
             }
           </td>
         </tr>

src/app/features/meetings/pages/meeting-details/meeting-details.component.ts

@@ -25,14 +25,14 @@ import { takeUntilDestroyed, toSignal } from '@angular/core/rxjs-interop';
 import { FormControl } from '@angular/forms';
 import { ActivatedRoute, Router, RouterLink } from '@angular/router';
 
-import { MEETING_SUBMISSIONS_TABLE_PARAMS } from '@osf/features/meetings/constants';
-import { MeetingSubmission } from '@osf/features/meetings/models';
-import { GetMeetingById, GetMeetingSubmissions, MeetingsSelectors } from '@osf/features/meetings/store';
-import { parseQueryFilterParams } from '@osf/shared/helpers/http.helper';
-import { SearchInputComponent, SubHeaderComponent } from '@shared/components';
-import { SortOrder } from '@shared/enums';
-import { QueryParams, TableParameters } from '@shared/models';
-import { SearchFilters } from '@shared/models/filters';
+import { SearchInputComponent, SubHeaderComponent } from '@osf/shared/components';
+import { SortOrder } from '@osf/shared/enums';
+import { parseQueryFilterParams } from '@osf/shared/helpers';
+import { QueryParams, SearchFilters, TableParameters } from '@osf/shared/models';
+
+import { MEETING_SUBMISSIONS_TABLE_PARAMS } from '../../constants';
+import { MeetingSubmission } from '../../models';
+import { GetMeetingById, GetMeetingSubmissions, MeetingsSelectors } from '../../store';
 
 @Component({
   selector: 'osf-meeting-details',