Update deleteSegmentList to include parentSegmentId in the request body

Author: zackcl

backend/packages/Upgrade/test/unit/controllers/SegmentController.test.ts

@@ -154,16 +154,15 @@ describe('Segment Controller Testing', () => {
       .expect(200);
   });
 
-  // TODO: Should be uncommented once the backend endpoint is implemented
-  // test('Delete request for /api/segments/list/:segmentId (deleteSegmentList)', () => {
-  //   const segmentId = uuid();
-  //   const parentSegmentId = uuid();
-
-  //   return request(app)
-  //     .delete(`/api/segments/list/${segmentId}`)
-  //     .send({ parentSegmentId })
-  //     .set('Accept', 'application/json')
-  //     .expect('Content-Type', /json/)
-  //     .expect(200);
-  // });
+  test('Delete request for /api/segments/list/:segmentId (deleteSegmentList)', () => {
+    const segmentId = uuid();
+    const parentSegmentId = uuid();
+
+    return request(app)
+      .delete(`/api/segments/list/${segmentId}`)
+      .send({ parentSegmentId })
+      .set('Accept', 'application/json')
+      .expect('Content-Type', /json/)
+      .expect(200);
+  });
 });

frontend/projects/upgrade/src/app/core/segments/segments.data.service.ts

@@ -147,8 +147,8 @@ export class SegmentsDataService {
     );
   }
 
-  deleteSegmentList(segmentId: string) {
+  deleteSegmentList(segmentId: string, parentSegmentId: string) {
     const url = `${this.environment.api.addSegmentList}/${segmentId}`;
-    return this.http.delete(url);
+    return this.http.delete(url, { body: { parentSegmentId } });
   }
 }

frontend/projects/upgrade/src/app/core/segments/segments.service.ts

@@ -231,7 +231,12 @@ export class SegmentsService {
     this.store$.dispatch(SegmentsActions.actionUpdateSegmentList({ list }));
   }
 
-  deletePrivateSegmentList(segmentId: string) {
-    this.store$.dispatch(SegmentsActions.actionDeleteSegmentList({ segmentId }));
+  deletePrivateSegmentList(segmentId: string, parentSegmentId: string) {
+    this.store$.dispatch(
+      SegmentsActions.actionDeleteSegmentList({
+        segmentId,
+        parentSegmentId,
+      })
+    );
   }
 }

frontend/projects/upgrade/src/app/core/segments/store/segments.actions.ts

@@ -155,7 +155,10 @@ export const actionUpdateSegmentListFailure = createAction(
   props<{ error: any }>()
 );
 
-export const actionDeleteSegmentList = createAction('[Segments] Delete Segment List', props<{ segmentId: string }>());
+export const actionDeleteSegmentList = createAction(
+  '[Segments] Delete Segment List',
+  props<{ segmentId: string; parentSegmentId: string }>()
+);
 
 export const actionDeleteSegmentListSuccess = createAction(
   '[Segments] Delete Segment List Success',

frontend/projects/upgrade/src/app/core/segments/store/segments.effects.ts

@@ -263,9 +263,8 @@ export class SegmentsEffects {
   deleteSegmentList$ = createEffect(() =>
     this.actions$.pipe(
       ofType(SegmentsActions.actionDeleteSegmentList),
-      map((action) => action.segmentId),
-      switchMap((segmentId) => {
-        return this.segmentsDataService.deleteSegmentList(segmentId).pipe(
+      switchMap(({ segmentId, parentSegmentId }) => {
+        return this.segmentsDataService.deleteSegmentList(segmentId, parentSegmentId).pipe(
           map(() => SegmentsActions.actionDeleteSegmentListSuccess({ segmentId })),
           catchError((error) => of(SegmentsActions.actionDeleteSegmentListFailure({ error })))
         );

frontend/projects/upgrade/src/app/features/dashboard/segments/pages/segment-details-page/segment-details-page-content/segment-lists-section-card/segment-lists-section-card.component.ts

@@ -109,7 +109,7 @@ export class SegmentListsSectionCardComponent {
       .afterClosed()
       .subscribe((confirmClicked) => {
         if (confirmClicked) {
-          this.segmentsService.deletePrivateSegmentList(segment.id);
+          this.segmentsService.deletePrivateSegmentList(segment.id, this.data.id);
         }
       });
   }