🐛 Bugfix to overwrite monitored document for unused decision points (#1482)

* bugfix to overwrite monitored document for unused decision points

* unit test cases fixed for multiple monitored document getting stored for unused dp

* version bump

---------

Co-authored-by: danoswaltCL <[email protected]>

Author: ppratikcr7

backend/package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "ab_testing_backend",
-    "version": "5.1.12",
+    "version": "5.1.13",
     "description": "Backend for A/B Testing Project",
     "scripts": {
         "install:all": "npm ci && cd packages/Scheduler && npm ci && cd ../Upgrade && npm ci",

backend/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ppl-upgrade-serverless",
-  "version": "5.1.12",
+  "version": "5.1.13",
   "description": "Serverless webpack example using Typescript",
   "main": "handler.js",
   "scripts": {

backend/packages/Scheduler/package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "ab_testing_backend",
-    "version": "5.1.12",
+    "version": "5.1.13",
     "description": "Backend for A/B Testing Project",
     "main": "index.js",
     "scripts": {

backend/packages/Scheduler/package.json

@@ -214,16 +214,15 @@ export class ExperimentAssignmentService {
 
     // experiment level inclusion and exclusion
     const [, exclusionReason] = await this.experimentLevelExclusionInclusion(globalFilteredExperiments, userDoc);
-    let monitoredDocument: MonitoredDecisionPoint;
+    let monitoredDocument: MonitoredDecisionPoint = await this.monitoredDecisionPointRepository.findOne({
+      where: {
+        site: site,
+        target: target,
+        user: userId,
+      },
+      relations: ['user'],
+    });
     if (experimentId && experiments.length) {
-      monitoredDocument = await this.monitoredDecisionPointRepository.findOne({
-        where: {
-          site: site,
-          target: target,
-          user: userId,
-        },
-        relations: ['user'],
-      });
       const selectedExperimentDP = dpExperiments.find((dp) => dp.experiment.id === experimentId);
       const experiment = experiments[0];
       const { conditions } = experiment;

backend/packages/Upgrade/package-lock.json

@@ -445,10 +445,19 @@ describe('Experiment Assignment Service Test', () => {
     const individualExclusionRepositoryMock = { findExcluded: sandbox.stub().resolves([]) };
     const groupEnrollmentRepositoryMock = { findEnrollments: sandbox.stub().resolves([]) };
     const groupExclusionRepositoryMock = { findExcluded: sandbox.stub().resolves([]) };
+    const monitoredDocument = {
+      site: site,
+      target: target,
+      condition: condition,
+      user: {
+        id: userId,
+      },
+    };
     const monitoredDecisionPointRepositoryMock = {
       saveRawJson: sandbox.stub().callsFake((args) => {
         return args;
       }),
+      findOne: sandbox.stub().resolves(monitoredDocument),
     };
 
     testedModule.decisionPointRepository = decisionPointRepositoryMock;
@@ -490,10 +499,19 @@ describe('Experiment Assignment Service Test', () => {
     const individualExclusionRepositoryMock = { findExcluded: sandbox.stub().resolves([]) };
     const groupEnrollmentRepositoryMock = { findEnrollments: sandbox.stub().resolves([]) };
     const groupExclusionRepositoryMock = { findExcluded: sandbox.stub().resolves([]) };
+    const monitoredDocument = {
+      site: site,
+      target: target,
+      condition: condition,
+      user: {
+        id: userId,
+      },
+    };
     const monitoredDecisionPointRepositoryMock = {
       saveRawJson: sandbox.stub().callsFake((args) => {
         return args;
       }),
+      findOne: sandbox.stub().resolves(monitoredDocument),
     };
 
     testedModule.decisionPointRepository = decisionPointRepositoryMock;

backend/packages/Upgrade/package.json

@@ -9,7 +9,7 @@
 		at the same time that happen to rev to the same new version will be caught 
 		by a merge conflict. -->
 
-	<version>5.1.12</version>
+	<version>5.1.13</version>
 	<build>
 		<plugins>
 			<plugin>