fix(tests): fail fast on unreadable files, correct INFO checks, add pest script

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

composer.json

@@ -14,5 +14,8 @@
         "files": [
             "tests/bootstrap.php"
         ]
+    },
+    "scripts": {
+        "test": "vendor/bin/pest"
     }
 }

tests/Security/Php74CompatibilityTest.php

@@ -19,79 +19,55 @@
 		'setup.php',
 	];
 
-	it('does not use str_contains (PHP 8.0)', function () use ($files) {
-		foreach ($files as $relativeFile) {
-			$path = realpath(__DIR__ . '/../../' . $relativeFile);
+	$readRequiredFile = function (string $relativeFile): string {
+		$path = realpath(__DIR__ . '/../../' . $relativeFile);
+
+		if ($path === false) {
+			throw new RuntimeException("Unable to resolve required file: {$relativeFile}");
+		}
+
+		$contents = file_get_contents($path);
 
-			if ($path === false) {
-				continue;
-			}
+		if ($contents === false) {
+			throw new RuntimeException("Unable to read required file: {$relativeFile}");
+		}
 
-			$contents = file_get_contents($path);
+		return $contents;
+	};
 
-			if ($contents === false) {
-				continue;
-			}
+	it('does not use str_contains (PHP 8.0)', function () use ($files, $readRequiredFile) {
+		foreach ($files as $relativeFile) {
+			$contents = $readRequiredFile($relativeFile);
 
 			expect(preg_match('/\bstr_contains\s*\(/', $contents))->toBe(0,
 				"{$relativeFile} uses str_contains() which requires PHP 8.0"
 			);
 		}
 	});
 
-	it('does not use str_starts_with (PHP 8.0)', function () use ($files) {
+	it('does not use str_starts_with (PHP 8.0)', function () use ($files, $readRequiredFile) {
 		foreach ($files as $relativeFile) {
-			$path = realpath(__DIR__ . '/../../' . $relativeFile);
-
-			if ($path === false) {
-				continue;
-			}
-
-			$contents = file_get_contents($path);
-
-			if ($contents === false) {
-				continue;
-			}
+			$contents = $readRequiredFile($relativeFile);
 
 			expect(preg_match('/\bstr_starts_with\s*\(/', $contents))->toBe(0,
 				"{$relativeFile} uses str_starts_with() which requires PHP 8.0"
 			);
 		}
 	});
 
-	it('does not use str_ends_with (PHP 8.0)', function () use ($files) {
+	it('does not use str_ends_with (PHP 8.0)', function () use ($files, $readRequiredFile) {
 		foreach ($files as $relativeFile) {
-			$path = realpath(__DIR__ . '/../../' . $relativeFile);
-
-			if ($path === false) {
-				continue;
-			}
-
-			$contents = file_get_contents($path);
-
-			if ($contents === false) {
-				continue;
-			}
+			$contents = $readRequiredFile($relativeFile);
 
 			expect(preg_match('/\bstr_ends_with\s*\(/', $contents))->toBe(0,
 				"{$relativeFile} uses str_ends_with() which requires PHP 8.0"
 			);
 		}
 	});
 
-	it('does not use nullsafe operator (PHP 8.0)', function () use ($files) {
+	it('does not use nullsafe operator (PHP 8.0)', function () use ($files, $readRequiredFile) {
 		foreach ($files as $relativeFile) {
-			$path = realpath(__DIR__ . '/../../' . $relativeFile);
-
-			if ($path === false) {
-				continue;
-			}
-
-			$contents = file_get_contents($path);
-
-			if ($contents === false) {
-				continue;
-			}
+			$contents = $readRequiredFile($relativeFile);
 
 			expect(preg_match('/\?->/', $contents))->toBe(0,
 				"{$relativeFile} uses nullsafe operator which requires PHP 8.0"

tests/Security/PreparedStatementConsistencyTest.php

@@ -27,13 +27,13 @@
 			$path = realpath(__DIR__ . '/../../' . $relativeFile);
 
 			if ($path === false) {
-				continue;
+				throw new RuntimeException("Unable to resolve required plugin file: {$relativeFile}");
 			}
 
 			$contents = file_get_contents($path);
 
 			if ($contents === false) {
-				continue;
+				throw new RuntimeException("Unable to read required plugin file: {$relativeFile}");
 			}
 
 			$lines                   = explode("\n", $contents);

tests/Security/SetupStructureTest.php

@@ -10,7 +10,17 @@
 // Verify setup.php defines required plugin hooks and info function.
 
 describe('maint setup.php structure', function () {
-	$source = file_get_contents(realpath(__DIR__ . '/../../setup.php'));
+	$setupPath = realpath(__DIR__ . '/../../setup.php');
+	expect($setupPath)->not->toBeFalse();
+
+	$source = file_get_contents($setupPath);
+	expect($source)->not->toBeFalse();
+
+	$infoPath = realpath(__DIR__ . '/../../INFO');
+	expect($infoPath)->not->toBeFalse();
+
+	$info = parse_ini_file($infoPath, true);
+	expect($info)->not->toBeFalse();
 
 	it('defines plugin_maint_install function', function () use ($source) {
 		expect($source)->toContain('function plugin_maint_install');
@@ -24,11 +34,11 @@
 		expect($source)->toContain('function plugin_maint_uninstall');
 	});
 
-	it('returns version array with name key', function () use ($source) {
-		expect($source)->toMatch('/[\'\""]name[\'\""]\s*=>/');
+	it('declares a name in INFO', function () use ($info) {
+		expect($info['info'])->toHaveKey('name');
 	});
 
-	it('returns version array with version key', function () use ($source) {
-		expect($source)->toMatch('/[\'\""]version[\'\""]\s*=>/');
+	it('declares a version in INFO', function () use ($info) {
+		expect($info['info'])->toHaveKey('version');
 	});
 });