fix(plugins): FileNotFoundError on usgs auth attempt failure (#1550)

Author: sbrunato

eodag/plugins/apis/usgs.py

@@ -128,7 +128,7 @@ def authenticate(self) -> None:
                 api.logout()
                 continue
             except USGSError as e:
-                if i == 0:
+                if i == 0 and os.path.isfile(api.TMPFILE):
                     # `.usgs` API file key might be obsolete
                     # Remove it and try again
                     os.remove(api.TMPFILE)

tests/units/test_apis_plugins.py

@@ -485,21 +485,28 @@ def test_plugins_apis_usgs_authenticate(self, mock_api_logout, mock_api_login):
             USGSError("USGS error"),
             None,
         ]
-        with mock.patch("os.remove", autospec=True) as mock_os_remove:
+        with (
+            mock.patch("os.remove", autospec=True) as mock_os_remove,
+            mock.patch("os.path.isfile", autospec=True) as mock_isfile,
+        ):
             self.api_plugin.authenticate()
             self.assertEqual(mock_api_login.call_count, 2)
             self.assertEqual(mock_api_logout.call_count, 0)
+            mock_isfile.assert_called_once_with(USGS_TMPFILE)
             mock_os_remove.assert_called_once_with(USGS_TMPFILE)
         mock_api_login.reset_mock()
         mock_api_logout.reset_mock()
 
         # with invalid credentials / USGSError
         mock_api_login.side_effect = USGSError()
-        with mock.patch("os.remove", autospec=True) as mock_os_remove:
-            with self.assertRaises(AuthenticationError):
-                self.api_plugin.authenticate()
-                self.assertEqual(mock_api_login.call_count, 2)
-                mock_api_logout.assert_not_called()
+        with (
+            mock.patch("os.remove", autospec=True),
+            mock.patch("os.path.isfile", autospec=True),
+            self.assertRaises(AuthenticationError),
+        ):
+            self.api_plugin.authenticate()
+            self.assertEqual(mock_api_login.call_count, 2)
+            mock_api_logout.assert_not_called()
 
     @mock.patch("usgs.api.login", autospec=True)
     @mock.patch("usgs.api.logout", autospec=True)
@@ -635,7 +642,6 @@ def test_plugins_apis_usgs_download(
 
         @responses.activate
         def run():
-
             product = EOProduct(
                 "peps",
                 dict(