fix:improve the type check for the json objects (#10)

Author: khaoulalabyad

example/07-get-tags-for-customer.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * This example lists out all tags for one customer.
+ *
+ * For any example to work, you must supply your own secrets in config.ini:
+ * - username
+ * - client
+ * - secret_key
+ */
+
+use BrightFlair\SpektrixAPI\CustomerNotFoundException;
+
+chdir(dirname(__DIR__));
+require "vendor/autoload.php";
+
+$config = parse_ini_file("config.ini");
+$client = new BrightFlair\SpektrixAPI\Client(
+	$config["username"],
+	$config["client"],
+	$config["secret_key"],
+);
+
+$email = $argv[1] ?? null;
+if(!$email) {
+	fwrite(STDERR, "No email address supplied\n");
+	exit(1);
+}
+$tagList =[];
+
+try {
+	$customer = $client->getCustomer(email: $email);
+	echo "Customer found!\n";
+	echo "ID: $customer->id\n";
+	echo "Email: $customer->email\n";
+	echo "First name: $customer->firstName\n";
+	echo "Last name: $customer->lastName\n";
+	$tagList = $client->getTagsForCustomer($customer);
+
+}
+catch(CustomerNotFoundException) {
+	echo "No customer was found with the email address $email\n";
+}
+echo "There are " . count($tagList) . " tags on the account:\n";
+
+foreach($tagList as $i => $tag) {
+	echo $i + 1;
+	echo ": ";
+	echo $tag->name;
+	echo " ($tag->id)";
+	echo "\n";
+}

src/Client.php

@@ -143,17 +143,24 @@ public function getTagsForCustomer(Customer|string $customer):array {
 		);
 
 		$tagList = [];
-		/** @var JsonArrayPrimitive $jsonArray */
-		$jsonArray = $this->json($authenticatedRequest);
-		foreach($jsonArray->getPrimitiveValue() as $item) {
-			array_push(
-				$tagList,
-				new Tag(
-					$item->getString("id"),
-					$item->getString("name"),
-				)
-			);
+		$json = $this->json($authenticatedRequest);
+
+		if ($json instanceof JsonArrayPrimitive) {
+
+
+			foreach ($json->getPrimitiveValue() as $item) {
+				array_push(
+					$tagList,
+					new Tag(
+						$item->getString("id"),
+						$item->getString("name")
+					)
+				);
+
+			}
+
 		}
+
 		return $tagList;
 	}
 

test/phpunit/ClientTest.php

@@ -234,8 +234,9 @@ public function testGetTagsForCustomer():void {
 		$expectedUri = str_replace("{id}", $customerId, $expectedUri);
 
 		$fetchClient = self::getFetchClient($expectedUri, 200, [
-			["id" => "id-1", "name" => "name-1"],
-			["id" => "id-2", "name" => "name-2"],
+
+				["id" => "id-1", "name" => "name-1"],
+				["id" => "id-2", "name" => "name-2"],
 		]);
 
 		$sut = new Client(self::TEST_USERNAME, self::TEST_CLIENT, self::TEST_SECRET_KEY, $fetchClient);