Skip to content

Commit e6f4ef4

Browse files
committed
Use command smoke defaults for reliable integration runs
1 parent 350d4ee commit e6f4ef4

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/integration-feature-matrix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
promotion-strategy: ${{ matrix.strategy }}
104104
gradual-steps: ${{ matrix.gradual_steps }}
105105
gradual-step-wait-seconds: ${{ vars.CF_GRADUAL_STEP_WAIT_SECONDS || '20' }}
106-
smoke-test-url: ${{ vars.CF_STAGING_SMOKE_URL || vars.CF_PRODUCTION_SMOKE_URL || 'https://example.com' }}
106+
smoke-test-url: ${{ vars.CF_STAGING_SMOKE_URL || vars.CF_PRODUCTION_SMOKE_URL }}
107107
smoke-test-expected-status: ${{ vars.CF_SMOKE_EXPECTED_STATUS || '200' }}
108108
smoke-test-expected-body-contains: ${{ vars.CF_SMOKE_EXPECTED_BODY || 'Example Domain' }}
109109
smoke-test-command: "node -e \"console.log('smoke command ok')\""

.github/workflows/integration-merge-promotion.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
promotion-strategy: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs['promotion-strategy'] || 'immediate' }}
103103
gradual-steps: ${{ vars.CF_GRADUAL_STEPS || '10,50,100' }}
104104
gradual-step-wait-seconds: ${{ vars.CF_GRADUAL_STEP_WAIT_SECONDS || '30' }}
105-
smoke-test-url: ${{ vars.CF_PRODUCTION_SMOKE_URL || 'https://example.com' }}
105+
smoke-test-url: ${{ vars.CF_PRODUCTION_SMOKE_URL }}
106106
smoke-test-expected-status: ${{ vars.CF_SMOKE_EXPECTED_STATUS || '200' }}
107107
smoke-test-expected-body-contains: ${{ vars.CF_SMOKE_EXPECTED_BODY || 'Example Domain' }}
108108
smoke-test-command: "node -e \"console.log('smoke command ok')\""

.github/workflows/integration-pr-validation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ jobs:
9797
promotion-strategy: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs['promotion-strategy'] || 'gradual' }}
9898
gradual-steps: ${{ vars.CF_GRADUAL_STEPS || '10,50,100' }}
9999
gradual-step-wait-seconds: ${{ vars.CF_GRADUAL_STEP_WAIT_SECONDS || '30' }}
100-
smoke-test-url: ${{ vars.CF_STAGING_SMOKE_URL || vars.CF_PRODUCTION_SMOKE_URL || 'https://example.com' }}
100+
smoke-test-url: ${{ vars.CF_STAGING_SMOKE_URL || vars.CF_PRODUCTION_SMOKE_URL }}
101101
smoke-test-expected-status: ${{ vars.CF_SMOKE_EXPECTED_STATUS || '200' }}
102102
smoke-test-expected-body-contains: ${{ vars.CF_SMOKE_EXPECTED_BODY || 'Example Domain' }}
103103
smoke-test-command: "node -e \"console.log('smoke command ok')\""

.github/workflows/integration-release-promotion.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
gradual-steps: ${{ vars.CF_GRADUAL_STEPS || '10,50,100' }}
132132
gradual-step-wait-seconds: ${{ vars.CF_GRADUAL_STEP_WAIT_SECONDS || '30' }}
133133
post-step-smoke-tests: 'true'
134-
smoke-test-url: ${{ vars.CF_PRODUCTION_SMOKE_URL || 'https://example.com' }}
134+
smoke-test-url: ${{ vars.CF_PRODUCTION_SMOKE_URL }}
135135
smoke-test-expected-status: ${{ vars.CF_SMOKE_EXPECTED_STATUS || '200' }}
136136
smoke-test-expected-body-contains: ${{ vars.CF_SMOKE_EXPECTED_BODY || 'Example Domain' }}
137137
smoke-test-command: "node -e \"console.log('smoke command ok')\""

0 commit comments

Comments
 (0)