moves ghidra installation into an action

Author: ivg

.github/actions/install-ghidra/action.yml

@@ -0,0 +1,25 @@
+name: "Installs Ghidra"
+description: "Installs ghidra libraries and data into the /usr prefix"
+inputs:
+  path:
+    description: "A path to the bap repository root"
+    default: ${{ github.workspace }}
+
+runs:
+  using: composite
+  steps:
+   - name: Cache Ghidra
+     id: cache-ghidra
+     uses: actions/cache@v4
+     with:
+       path: ghidra
+       key: ${{ runner.os }}-ghidra-${{ hashFiles(format('{0}/tools/install-ghidra.sh', inputs.path)) }}
+
+   - name: Build Ghidra
+     if: steps.cache-ghidra.outputs.cache-hit != 'true'
+     run: sudo sh ./${{inputs.path}}/tools/install-ghidra.sh ghidra
+     shell: bash
+
+   - name: Install Ghidra
+     run: sudo cp -r ghidra/* /usr/
+     shell: bash

.github/workflows/nightly.yml

@@ -29,25 +29,16 @@ jobs:
           repository: BinaryAnalysisPlatform/bap
           path: bap
 
+      - name: Install Ghidra
+        uses: ./bap/.github/actions/install-ghidra
+        with:
+          path: bap
+
       - name: Install Extra System Dependencies
         run: |
           sudo apt-get update -y
           sudo apt-get install dejagnu -y
 
-      - name: Cache Ghidra
-        id: cache-ghidra
-        uses: actions/cache@v4
-        with:
-          path: |
-            /usr/share/ghidra
-            /usr/lib/ghidra
-            /usr/include/ghidra
-          key: ${{ runner.os }}-ghidra-${{ hashFiles('bap/tools/install-ghidra.sh') }}
-
-      - name: Build and Install Ghidra
-        if: steps.cache-ghidra.outputs.cache-hit != 'true'
-        run: sudo sh ./bap/tools/install-ghidra.sh
-
       - name: Use OCaml ${{ matrix.ocaml-compiler }}
         uses: ocaml/setup-ocaml@v3
         with: