Fixes found with GCC-15 (eBay#289)

Author: szmyd

.gitignore

@@ -113,3 +113,4 @@ CMakeUserPresets.json
 logs/
 conan.lock
 graph_info.json
+.vsconan/config.json

conanfile.py

@@ -9,7 +9,7 @@
 
 class SISLConan(ConanFile):
     name = "sisl"
-    version = "13.1.0"
+    version = "13.1.1"
 
     homepage = "https://github.com/eBay/sisl"
     description = "Library for fast data structures, utilities"

include/sisl/utility/atomic_counter.hpp

@@ -37,7 +37,7 @@ class atomic_counter {
     atomic_counter(const atomic_counter& other) : m_count{other.m_count.load(std::memory_order_acquire)} {}
     atomic_counter(atomic_counter&& other) noexcept : m_count{std::move(other.m_count)} {}
     atomic_counter& operator=(const atomic_counter& rhs) {
-        if (this != &rhs) { m_count.store(rhs.load(std::memory_order_acquire), std::memory_order_release); }
+        if (this != &rhs) { m_count.store(rhs.m_count.load(std::memory_order_acquire), std::memory_order_release); }
         return *this;
     }
     atomic_counter& operator=(atomic_counter&& rhs) noexcept {