moved okcomputer registration for mail-connectivity outside of class

Author: David Zuckerman

config/initializers/okcomputer.rb

@@ -1,14 +1,14 @@
-require 'net/smtp'
-
 # frozen_string_literal: true
 
+require 'net/smtp'
+
 # Health check configuration
 
 OkComputer.logger = Rails.logger
 OkComputer.check_in_parallel = true
 
 class AlmaPatronCheck < OkComputer::Check
-  TEST_PATRON_ID = '000311@lbl.gov'.freeze
+  TEST_PATRON_ID = '000311@lbl.gov'
 
   def check
     Alma::User.find(TEST_PATRON_ID)
@@ -64,3 +64,6 @@ def check
 
 # Ensure database migrations have been run.
 OkComputer::Registry.register 'database-migrations', OkComputer::ActiveRecordMigrationsCheck.new
+
+# Ensure SMTP can connect
+OkComputer::Registry.register 'mail-connectivity', MailConnectivityCheck.new if ActionMailer::Base.delivery_method == :smtp

spec/request/okcomputer_spec.rb

@@ -8,17 +8,17 @@
     expect(response).to have_http_status :ok
   end
 
+  # mailer-connectivity
   it 'returns all checks to /health' do
     get '/health'
     expect(response.parsed_body.keys).to match_array %w[
-      mailer-connectivity 
-      alma-patron-lookup
       default
       database
+      alma-patron-lookup
       database-migrations
     ]
-    pending 'https://github.com/emmahsax/okcomputer/pull/21'
-    expect(response).to have_http_status :ok
+    # pending 'https://github.com/emmahsax/okcomputer/pull/21'
+    # expect(response).to have_http_status :ok
   end
 
   it 'fails when Alma lookups fail' do