Update Framework to Rails 7.1

Dockerfile:

  * Replace `libvips42` with `libyaml-dev`

    We have never used VIPS in Framework; this was mistakenly copied
    from UCBEARS.  We need libyaml-dev for the `psych` gem that Rails
    7.1's required `irb` pulls in.

  * Update Bundler to 2.7.2

    Otherwise, we hit a lot of duplicate constant errors when bundling.

Gemfile:

  * Remove the Gems that Rails explicitly requires now

    We only had `drb` and `mutex_m` to avoid Ruby 3.3 deprecation
    warnings.

  * Update Good Job to at least 3.25

    3.25 is the minimum for Rails 7.1 compatibility.  We pin to lower
    than 3.99.0 because we aren't ready to migrate to 4.x yet.

  * Update Rails to 7.1.6

  * Change `mingw mswin x64_mingw` to `windows`

    This is part of the Bundler 2.7 update.

  * Update database_cleaner to at least 2.1

    This is the minimum version for Rails 7.1 compatibility.

  * Update RSpec to 3.13

    This is required for the `receive(…).with(…)` syntax to work
    correctly on Rails 7.1.

  * Update RSpec-Rails to 6.1

    This update is necessary for Rails 7.1 compatibility and removes
    multiple deprecation warnings.

  * Update simplecov Gems

    This is required for Rails 7.1 compatibility.

TindDownloadController:

  * Add `_options` param to the cache fetch block

    This is a new addition in Rails 7.1.

jobs:

  * Don't `require 'request_mailer'`

    Rails 7.1 no long adds autoloaded paths to `$LOAD_PATH`.  The
    documentation clearly states you should not be requiring files
    autoloaded anyway, so stop doing that.

config:

  * Updates for Rails 7.1 compatibility

    Note that after this is live, rolling back to Rails 7.0 will
    require invalidation of cache as the cache format on-disk has
    changed with 7.1 defaults.

db:

  * Update Good Job schema

    This is required to update past 3.15.3.

spec:

  * Completely rewrite async_job_context

    Good Job has had a lot of internal rework, and the old way we were
    doing this wasn't working.  The new way uses a lot fewer "private"
    APIs, and hopefully this new code will serve us well as we continue
    to update.

Closes: AP-561
Ref: AP-270

Author: awilfox

.idea/altmedia.iml

@@ -39,7 +39,7 @@ RUN apt-get install -y --no-install-recommends \
     git \
     gpg \
     libpq-dev \
-    libvips42
+    libyaml-dev
 
 # Install Node.js and Yarn from their own repositories
 
@@ -108,7 +108,7 @@ RUN apt-get install -y --no-install-recommends \
 USER $APP_USER
 
 # Base image ships with an older version of bundler
-RUN gem install bundler --version 2.5.22
+RUN gem install bundler --version 2.7.2
 
 # Install gems. We don't enforce the validity of the Gemfile.lock until the
 # final (production) stage.

Dockerfile

@@ -13,16 +13,14 @@ gem 'berkeley_library-tind', '~> 0.8.0'
 gem 'berkeley_library-util', '~> 0.2.0'
 gem 'bootstrap'
 gem 'dotenv-rails', '~> 2.8.1', require: 'dotenv/rails-now'
-gem 'drb'
 gem 'faraday'
-gem 'good_job', '~> 3.10', '>= 3.14.2'
+gem 'good_job', '~> 3.25', '< 3.99.0'
 gem 'ipaddress'
 gem 'jaro_winkler', '~> 1.5.5'
 gem 'jquery-rails'
 gem 'jquery-ui-rails'
 gem 'jwt', '~> 1.5', '>= 1.5.4'
 gem 'lograge', '>=0.11.2'
-gem 'mutex_m'
 gem 'netaddr', '~> 1.5', '>= 1.5.1'
 gem 'net-ssh'
 gem 'okcomputer', '~> 1.19'
@@ -31,21 +29,21 @@ gem 'omniauth-cas', '~> 2.0'
 gem 'pg', '~> 1.2'
 gem 'prawn', '~> 2.4'
 gem 'puma', '~> 4.3', '>= 4.3.12'
-gem 'rails', '~> 7.0.4'
+gem 'rails', '~> 7.1.6'
 gem 'recaptcha', '~> 4.13'
 gem 'sprockets', '~> 4.0'
-gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
+gem 'tzinfo-data', platforms: %i[windows jruby]
 
 group :development, :test do
   gem 'brakeman'
   gem 'bundle-audit'
-  gem 'byebug', platforms: %i[mri mingw x64_mingw]
+  gem 'byebug', platforms: %i[mri windows]
   gem 'colorize'
-  gem 'database_cleaner-active_record', '~> 2.0'
+  gem 'database_cleaner-active_record', '~> 2.1'
   gem 'roo', '~> 2.8'
-  gem 'rspec', '~> 3.10'
+  gem 'rspec', '~> 3.13'
   gem 'rspec_junit_formatter', '~> 0.5'
-  gem 'rspec-rails', '~> 5.0'
+  gem 'rspec-rails', '~> 6.1'
   gem 'ruby-prof', '~> 1.3.0'
   gem 'webmock'
 end
@@ -65,6 +63,6 @@ group :test do
   gem 'capybara', '~> 3.36'
   gem 'concurrent-ruby', '~> 1.1'
   gem 'selenium-webdriver', '~> 4.0'
-  gem 'simplecov', '~> 0.21', require: false
-  gem 'simplecov-rcov', '~> 0.2', require: false
+  gem 'simplecov', '~> 0.22', require: false
+  gem 'simplecov-rcov', '~> 0.3.7', require: false
 end