moved some common dev and production settings to base in Dockerfile, fixed some annotation warning

Author: David Zuckerman

Dockerfile

@@ -14,13 +14,18 @@ RUN groupadd -g 40054 alma && \
 # Get list of available packages
 RUN apt-get -y update -qq
 
+COPY --chown=bfs . /opt/app
+
+ENTRYPOINT ["/opt/app/bin/bfs"]
+CMD ["help"]
+
 # ===============================================
 # Target: development
 # ===============================================
 
-from base AS development
+FROM base AS development
 
-user root
+USER root
 
 RUN apt-get -y --no-install-recommends install \
     build-essential \
@@ -36,23 +41,18 @@ COPY --chown=bfs Gemfile* .ruby-version ./
 RUN bundle config set force_ruby_platform true
 RUN bundle config set system 'true'
 RUN bundle install
-COPY --chown=bfs:bfs . .
 
-ENTRYPOINT ["/opt/app/bin/bfs"]
-CMD ["help"]
+# COPY --chown=bfs:bfs . .
 
 # =================================
 # Target: production
 # =================================
 FROM base AS production
 
 # Copy the built codebase from the dev stage
-COPY --from=development --chown=bfs /opt/app /opt/app
+# COPY --from=development --chown=bfs /opt/app /opt/app
 COPY --from=development --chown=bfs /usr/local/bundle /usr/local/bundle
 
 WORKDIR /opt/app
 RUN bundle config set frozen 'true'
 RUN bundle install --local
-
-ENTRYPOINT ["/opt/app/bin/bfs"]
-CMD ["help"]