Addressed review feedback

Author: amarzavery

lib/validators/specResolver.js

@@ -657,31 +657,20 @@ class SpecResolver {
     // Adding the model name or it's discriminator value as an enum constraint with one value (constant) on property marked as discriminator
     if (definitions[name] && definitions[name].properties && definitions[name].properties[discriminator]) {
       let val = name;
-      let discriminatorType = 'string';
       if (definitions[name]['x-ms-discriminator-value']) {
         val = definitions[name]['x-ms-discriminator-value'];
       }
-      // Ensure that the property marked as a discriminator has only one enum constraint and it should be the one that we want to set as a constant.
-      if (definitions[name].properties[discriminator].enum) {
-        delete definitions[name].properties[discriminator].enum;
-      }
+      // Ensure that the property marked as a discriminator has only one value in the enum constraint for that model and it 
+      // should be the one that is the model name or the value indicated by x-ms-discriminator-value. This will make the discriminator
+      // property a constant (in json schema terms).
       if (definitions[name].properties[discriminator]['$ref']) {
-        let obj;
-        try {
-          obj = utils.getObject(this.specInJson, definitions[name].properties[discriminator]['$ref'].slice(1));
-          if (obj && obj.type) {
-            discriminatorType = obj.type;
-          }
-        } catch (err) {
-          // do nothing, we tried to find the object and it's type. We will set it to "string" by default. It is safe to assume that properties
-          // marked as "discriminator" will be of type "string" as it needs to refer to a model definition name which logically should be a 
-          // string as it is the key in the definitions object in the swagger spec.
-        }
         delete definitions[name].properties[discriminator]['$ref'];
       }
-      // Set the type if not set.
+      // We will set "type" to "string". It is safe to assume that properties marked as "discriminator" will be of type "string"
+      // as it needs to refer to a model definition name. Model name would be a key in the definitions object/dictionary in the
+      // swagger spec. keys would always be a string in a JSON object/dictionary. 
       if (!definitions[name].properties[discriminator].type) {
-        definitions[name].properties[discriminator].type = discriminatorType;
+        definitions[name].properties[discriminator].type = 'string';
       }
       definitions[name].properties[discriminator].enum = [`${val}`];
     }