-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Open
Description
Apply TypeSpec client customizations to address APIView feedback comments.
Current Task
Package Name: azure-contoso-widgetmanager
Language: Python
APIView URL: https://spa.apiviewstagingtest.com/review/c69cb49cfc1543cf809dcfcf1b74ff07?activeApiRevisionId=4e4acd1bc7b4443f81885a5fba2d8000
Commit SHA: fdecbc4
Feedback to Address
APIView Comments (5 unresolved)
| LineNo | Element | LineText | CommentText |
|---|---|---|---|
| 124 | azure.contoso.widgetmanager.models.FakedSharedModel | class azure.contoso.widgetmanager.models.FakedSharedModel(MutableMapping[str, Any]): | Redundant - This name shouldn't end with "Model". |
| 79 | azure.contoso.widgetmanager.aio.operations.WidgetsOperations.begin_create_or_update_widget:async_2.param(widget_name) | widget_name: str, | Remove "widget_". It's redundant. |
| 119 | azure.contoso.widgetmanager.aio.operations.WidgetsOperations.list_widgets | def list_widgets(self, **kwargs: Any) -> AsyncItemPaged[WidgetSuite] | Add the required parameter 'hat' of type string. |
| 141 | azure.contoso.widgetmanager.models.OperationState.CANCELED | CANCELED = "Canceled" | Keep the spelling as is since 'cancelled' and 'canceled' are both used in the TypeSpec for consistency with current usage. |
| 101 | azure.contoso.widgetmanager.aio.operations.WidgetsOperations.begin_delete_widget:async.returntype | ) -> AsyncLROPoller[WidgetSuite] | Return None for all delete operations using TypeSpec to implement the change. |
Constraints
- Apply TypeSpec client customizations to resolve as many comments as possible
- MUST consult: https://github.com/Azure/azure-rest-api-specs/blob/main/eng/common/knowledge/customizing-client-tsp.md
Output Requirements
-
If a Commit SHA is provided, use it as the base for your changes
-
Include the APIView URL
-
PR description MUST include a markdown table with three columns:
LineNo Addressed? Summary For each comment:
- If addressed: Yes, and a brief summary of the changes made
- If not addressed: No, and explain why (e.g., information is unclear, TypeSpec doesn't support this customization and SDK code customization is needed)
-
For SDK code customization guidance, see: https://github.com/Azure/autorest.python/blob/main/docs/customizations.md
Auto-generated by feedback customizations tool
Reactions are currently unavailable