Skip to content

Commit da38a51

Browse files
Nikschavanmatticbot
authored andcommitted
CHARTS-148 - fix: use flex layout for ConversionFunnelChart to fill container height (#47119)
* fix: use flex layout for ConversionFunnelChart to fill container height Switch from a fixed 200px height to a flex layout so the conversion funnel chart can grow to fill its parent container. * chore: remove packed charts tarball from repo * fix: add height prop to ConversionFunnelChart for backward compatibility Default height to 200px to maintain the original chart size when no height is passed, while allowing consumers to override with values like "100%" to fill their container. * fix: add missing JSDoc @param for height prop * fix: default ConversionFunnelChart to 100% height and use WordPress UI Stack Replace custom flex layout with WordPress UI Stack component for layout consistency. Default height changed from 200px to 100% so the chart fills its parent container, matching other chart components in the library. The height prop remains available for explicit fixed sizing. * fix: resolve ConversionFunnelChart height with proper fallback chain Use height prop > style.height > 100% default instead of always defaulting the prop, which would override style.height. * fix: add min-height fallback, height prop tests, and docs clarification Set min-height: 200px on the chart content area to prevent collapse when the parent container lacks an explicit height. Add unit tests covering the height prop fallback chain and update docs to note the parent container height requirement. * fix: use data-testid in height tests instead of container.firstChild Add data-testid to ConversionFunnelChart root element and refactor height prop tests to use screen.getByTestId, removing eslint-disable comments for testing-library/no-node-access. * docs: fix indentation in ConversionFunnelChart height usage example Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/22173015845 Upstream-Ref: Automattic/jetpack@a7d4fbc
1 parent 8c2377e commit da38a51

File tree

0 file changed

+0
-0
lines changed

    0 file changed

    +0
    -0
    lines changed

    0 commit comments

    Comments
     (0)