PR: Be able to set other Content-Type rather than "text/html"#16
Open
vlaicu95 wants to merge 1 commit intoAnna-Rx:masterfrom
Open
PR: Be able to set other Content-Type rather than "text/html"#16vlaicu95 wants to merge 1 commit intoAnna-Rx:masterfrom
vlaicu95 wants to merge 1 commit intoAnna-Rx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content-Type is always set by default to "text/html" in the constructor of Response class.
If you want to create a response with a image or something different and you provide the new Content-Type in the headers dictionary passed in the constructor an exception is thrown when it tries to add the new "Content-Type" because the Add method was used. This method checks if the same key is present and throws.
One workaround that I used, was to create the response and manually overwrite because the Headers member is public but this approach forces you not to write inline clean code.
This is definitely a bug and in order to solve it the Add method was replaced with []. In this case the content type can be overwritten and also other headers can be added.