Skip to content

[IOTOF] Update in the TOF digitization#15493

Open
GiorgioAlbertoLucia wants to merge 28 commits into
AliceO2Group:devfrom
GiorgioAlbertoLucia:iotofdigi
Open

[IOTOF] Update in the TOF digitization#15493
GiorgioAlbertoLucia wants to merge 28 commits into
AliceO2Group:devfrom
GiorgioAlbertoLucia:iotofdigi

Conversation

@GiorgioAlbertoLucia

Copy link
Copy Markdown
Contributor

Main updates in the digitization

  • new values for the segmentation
  • the writer and reader class were fully implemented
  • the digitization is now done by first filling the chips, then streaming the digits in the chip to the output
  • the digitization reconstruction workflow was implemented and tested

The output digits was tested with a dedicated simulation

  • pions were injected with a gun to a target pixel
  • the map of the hits was visualized (as points) in the local coordinates of the chip
  • the map of the recorded digits was visualized both in the row/column and in the x/z local coordinates of the chip
  • the maps of the recorded digits and of the hits were superimposed to check that the two were consistent
Screenshot 2026-06-05 at 18 03 01 Map of the recorded digits in the row/column grid Screenshot 2026-06-05 at 18 03 17 Map of the recorded digits in the local coordinates of the chip Screenshot 2026-06-05 at 18 03 34 Superposition of the recorded digits and of the hits in the local coordinates of the chip Screenshot 2026-06-05 at 18 03 48 Zoom in

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review June 6, 2026 16:26
njacazio
njacazio previously approved these changes Jun 9, 2026
@njacazio njacazio enabled auto-merge (squash) June 9, 2026 08:42
@njacazio

njacazio commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

@shahor02 @sawenzel could you also give it a look? Many thanks!

@shahor02 shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, superficially, looks fine, just 1 comment below.

Comment on lines +24 to +52
template <int N>
struct DPLDigitizerParam : public o2::conf::ConfigurableParamHelper<DPLDigitizerParam<N>> {
static_assert(N == o2::detectors::DetID::TF3, "only DetID::TF3 is allowed");

static constexpr std::string_view getParamName()
{
return ParamName[0];
}

bool continuous = true; ///< flag for continuous simulation
float noisePerPixel = DEFNoisePerPixel(); ///< ALPIDE Noise per channel
float strobeFlatTop = 20.; ///< strobe shape flat top
float strobeMaxRiseTime = 0.; ///< strobe max rise time
float strobeQRiseTime0 = 0.; ///< q @ which strobe rise time is 0

double timeOffset = 0.; ///< time offset (in seconds!) to calculate ROFrame from hit time
int chargeThreshold = 75; ///< charge threshold in Nelectrons
int minChargeToAccount = 7; ///< minimum charge contribution to account
int nSimSteps = 475; ///< number of steps in response simulation
float energyToNElectrons = 1. / 3.6e-9; // conversion of eloss to Nelectrons

float Vbb = 0.0; ///< back bias absolute value for MFT (in Volt)
float IBVbb = 0.0; ///< back bias absolute value for ITS Inner Barrel (in Volt)
float OBVbb = 0.0; ///< back bias absolute value for ITS Outter Barrel (in Volt)

std::string noiseFilePath{}; ///< optional noise masks file path. FIXME to be removed once switch to CCDBFetcher

// boilerplate stuff + make principal key
O2ParamDef(DPLDigitizerParam, getParamName().data());

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a template? Also, the voltage data members seem to be tailored for Run3 ITS/MFT.

Removed template parameter from DPLDigitizerParam structure and adjusted inheritance.
auto-merge was automatically disabled June 9, 2026 09:43

Head branch was pushed to by a user without write access

@alibuild

alibuild commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for ae89dd4 at 2026-06-09 12:20:

## sw/BUILD/O2-latest/log
input_line_9:564:3: error: constexpr variable 'sKey' must be initialized by a constant expression
Error: /sw/slc9_x86-64/ROOT/v6-36-10-alice1-1/bin/rootcling: compilation failure (/sw/BUILD/6ec8df0acb90317232233dcb6c35397a16a40358/O2/Detectors/Upgrades/ALICE3/IOTOF/simulation/G__O2IOTOFSimulation131b57f4c2_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

Please consider the following formatting changes to AliceO2Group#15493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants