fix: resolve spotbugs and errorprone warnings

- Replace QueueType[] array with List<QueueType> in QueueGroup record
  (fixes ArrayRecordComponent warning)
- Use Guava Splitter instead of String.split() in Config
  (fixes StringSplitter warning)
- Update Velocity command registration to use CommandMeta builder
  (fixes deprecation warning)

Author: AlexProgrammerDE

shared/src/main/java/net/pistonmaster/pistonqueue/shared/config/Config.java

@@ -19,6 +19,7 @@
  */
 package net.pistonmaster.pistonqueue.shared.config;
 
+import com.google.common.base.Splitter;
 import de.exlll.configlib.Comment;
 import de.exlll.configlib.Configuration;
 import de.exlll.configlib.Ignore;
@@ -613,7 +614,7 @@ private void rebuildKickWhenDownServers() {
       }
 
       // Split by comma to support comma-separated server lists
-      for (String server : processed.split(",")) {
+      for (String server : Splitter.on(',').split(processed)) {
         String trimmed = server.trim();
         if (!trimmed.isEmpty() && !resolved.contains(trimmed)) {
           resolved.add(trimmed);
@@ -698,9 +699,9 @@ private void rebuildQueueGroups() {
       }
 
       List<String> typeNames = configuration.getQueueTypes();
-      QueueType[] groupTypes;
+      List<QueueType> groupTypes;
       if (typeNames.isEmpty()) {
-        groupTypes = queueTypeInstances.values().toArray(QueueType[]::new);
+        groupTypes = List.copyOf(queueTypeInstances.values());
       } else {
         groupTypes = typeNames.stream()
           .map(nameKey -> {
@@ -710,7 +711,7 @@ private void rebuildQueueGroups() {
             }
             return type;
           })
-          .toArray(QueueType[]::new);
+          .toList();
       }
 
       QueueGroup group = new QueueGroup(

shared/src/main/java/net/pistonmaster/pistonqueue/shared/plugin/PistonQueuePlugin.java

@@ -73,7 +73,7 @@ default void scheduleTasks(QueueListenerShared queueListener) {
     Config config = getConfiguration();
     QueueGroup resolvedDefaultGroup = config.getDefaultGroup();
     if (resolvedDefaultGroup == null) {
-      QueueType[] queueTypes = config.getAllQueueTypes().toArray(new QueueType[0]);
+      List<QueueType> queueTypes = config.getAllQueueTypes();
       resolvedDefaultGroup = new QueueGroup(
         "default",
         Collections.singletonList(config.queueServer()),

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/QueueGroup.java

@@ -19,18 +19,16 @@
  */
 package net.pistonmaster.pistonqueue.shared.queue;
 
-import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 
-public record QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, QueueType[] queueTypes) {
-  public QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, QueueType[] queueTypes) {
+public record QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, List<QueueType> queueTypes) {
+  public QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, List<QueueType> queueTypes) {
     this.name = name;
     this.queueServers = List.copyOf(queueServers);
     this.targetServers = List.copyOf(targetServers);
     this.sourceServers = List.copyOf(sourceServers);
-    this.queueTypes = queueTypes == null ? new QueueType[0] : queueTypes.clone();
+    this.queueTypes = queueTypes == null ? List.of() : List.copyOf(queueTypes);
   }
 
   /// Returns all queue servers configured for this group.
@@ -53,9 +51,4 @@ public boolean hasQueueServer(String server) {
     return queueServers.stream()
       .anyMatch(qs -> qs.toLowerCase(Locale.ROOT).equals(lowerServer));
   }
-
-  @Override
-  public QueueType[] queueTypes() {
-    return queueTypes.clone();
-  }
 }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/logic/QueueEnvironment.java

@@ -64,7 +64,7 @@ public QueueGroup defaultGroup() {
       return group;
     }
 
-    QueueType[] queueTypes = config.getAllQueueTypes().toArray(new QueueType[0]);
+    List<QueueType> queueTypes = config.getAllQueueTypes();
     return new QueueGroup(
       "default",
       List.of(config.queueServer()),

velocity/src/main/java/net/pistonmaster/pistonqueue/velocity/PistonQueueVelocity.java

@@ -99,7 +99,11 @@ public void onProxyInitialization(ProxyInitializeEvent event) {
     proxyServer.getChannelRegistrar().register(MinecraftChannelIdentifier.from("piston:queue"));
 
     info("Registering commands");
-    proxyServer.getCommandManager().register("pistonqueue", new MainCommand(this), "pq");
+    var commandMeta = proxyServer.getCommandManager().metaBuilder("pistonqueue")
+      .aliases("pq")
+      .plugin(this)
+      .build();
+    proxyServer.getCommandManager().register(commandMeta, new MainCommand(this));
 
     info("Registering listeners");
     proxyServer.getEventManager().register(this, queueListenerVelocity);