refactor: modernize plugin code

Author: AlexProgrammerDE

shared/src/main/java/net/pistonmaster/pistonqueue/shared/command/MainCommandShared.java

@@ -57,8 +57,8 @@ default void onCommand(CommandSourceWrapper sender, String[] args, PistonQueuePl
         sendLine(sender);
         sender.sendMessage(component().text("Queue stats").color(TextColorWrapper.GOLD));
         for (QueueGroup group : config.getQueueGroups()) {
-          sender.sendMessage(component().text(group.getName()).color(TextColorWrapper.GOLD));
-          for (QueueType type : group.getQueueTypes()) {
+          sender.sendMessage(component().text(group.name()).color(TextColorWrapper.GOLD));
+          for (QueueType type : group.queueTypes()) {
             sender.sendMessage(component().text(" - " + type.getName() + ": ").color(TextColorWrapper.GOLD)
               .append(component().text(String.valueOf(queueSize(type))).color(TextColorWrapper.GOLD).decorate(TextDecorationWrapper.BOLD)));
           }
@@ -74,8 +74,8 @@ default void onCommand(CommandSourceWrapper sender, String[] args, PistonQueuePl
         sendLine(sender);
         sender.sendMessage(component().text("Target slot stats").color(TextColorWrapper.GOLD));
         for (QueueGroup group : config.getQueueGroups()) {
-          sender.sendMessage(component().text(group.getName()).color(TextColorWrapper.GOLD));
-          for (QueueType type : group.getQueueTypes()) {
+          sender.sendMessage(component().text(group.name()).color(TextColorWrapper.GOLD));
+          for (QueueType type : group.queueTypes()) {
             sender.sendMessage(component().text(" - " + type.getName() + ": ").color(TextColorWrapper.GOLD)
               .append(component().text(type.getPlayersWithTypeInTarget().get() + " / " + type.getReservedSlots()).color(TextColorWrapper.GOLD).decorate(TextDecorationWrapper.BOLD)));
           }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/config/Config.java

@@ -740,11 +740,11 @@ private void rebuildQueueGroups() {
 
   private void registerGroup(QueueGroup group) {
     queueGroupList.add(group);
-    queueGroupsByName.put(group.getName().toLowerCase(Locale.ROOT), group);
-    for (String target : group.getTargetServers()) {
+    queueGroupsByName.put(group.name().toLowerCase(Locale.ROOT), group);
+    for (String target : group.targetServers()) {
       queueGroupsByTarget.put(target.toLowerCase(Locale.ROOT), group);
     }
-    for (QueueType type : group.getQueueTypes()) {
+    for (QueueType type : group.queueTypes()) {
       queueGroupByType.put(type, group);
     }
   }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/config/ConfigMigrator.java

@@ -29,9 +29,7 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-/**
- * Performs migrations of legacy configuration files to the new format.
- */
+/// Performs migrations of legacy configuration files to the new format.
 public final class ConfigMigrator {
   private static final Pattern CONFIG_VERSION_PATTERN = Pattern.compile("configVersion:\\s*(\\d+)");
   private static final Pattern QUEUE_SERVER_PATTERN = Pattern.compile("(\\s+)queueServer:\\s*\"?([^\"\\n]+)\"?");
@@ -102,7 +100,7 @@ private static String migrateV2ToV3(String content) {
     // Migrate queueServer to queueServers in queue groups
     // This regex finds queueServer entries within queueGroups section and converts them to queueServers list
     Matcher matcher = QUEUE_SERVER_PATTERN.matcher(result);
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     while (matcher.find()) {
       String indent = matcher.group(1);
       String serverName = matcher.group(2).trim();

shared/src/main/java/net/pistonmaster/pistonqueue/shared/events/PQServerConnectedEvent.java

@@ -23,9 +23,7 @@
 
 import java.util.Optional;
 
-/**
- * Event for when a player has successfully moved to another server on the proxy.
- */
+/// Event for when a player has successfully moved to another server on the proxy.
 public interface PQServerConnectedEvent {
   PlayerWrapper getPlayer();
 

shared/src/main/java/net/pistonmaster/pistonqueue/shared/events/PQServerPreConnectEvent.java

@@ -23,9 +23,7 @@
 
 import java.util.Optional;
 
-/**
- * Event for trying to connect to a server that allows us to intercept the connection and redirect the player.
- */
+/// Event for trying to connect to a server that allows us to intercept the connection and redirect the player.
 public interface PQServerPreConnectEvent {
   PlayerWrapper getPlayer();
 

shared/src/main/java/net/pistonmaster/pistonqueue/shared/plugin/PistonQueuePlugin.java

@@ -85,7 +85,7 @@ default void scheduleTasks(QueueListenerShared queueListener) {
     final QueueGroup defaultGroup = resolvedDefaultGroup;
     // Sends the position message and updates tab on an interval in chat
     schedule(() -> {
-      boolean targetsOnline = defaultGroup.getTargetServers().stream().anyMatch(queueListener.getOnlineServers()::contains);
+      boolean targetsOnline = defaultGroup.targetServers().stream().anyMatch(queueListener.getOnlineServers()::contains);
       if (targetsOnline) {
         for (QueueType type : config.getAllQueueTypes()) {
           if (config.positionMessageChat()) {
@@ -233,11 +233,11 @@ default void initializeReservationSlots() {
       Config config = getConfiguration();
       for (QueueGroup group : config.getQueueGroups()) {
         Map<QueueType, AtomicInteger> map = new HashMap<>();
-        for (QueueType type : group.getQueueTypes()) {
+        for (QueueType type : group.queueTypes()) {
           map.put(type, new AtomicInteger());
         }
 
-        for (String targetServerName : group.getTargetServers()) {
+        for (String targetServerName : group.targetServers()) {
           getServer(targetServerName).ifPresent(targetServer -> {
             for (PlayerWrapper player : targetServer.getConnectedPlayers()) {
               QueueType playerType = config.getQueueType(player);

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/BanType.java

@@ -19,22 +19,14 @@
  */
 package net.pistonmaster.pistonqueue.shared.queue;
 
-/**
- * How shadow-banned people should be punished.
- */
+/// How shadow-banned people should be punished.
 public enum BanType {
-  /**
-   * Loop forever in queue!
-   */
+  /// Loop forever in queue!
   LOOP,
 
-  /**
-   * Have a custom chance of getting into the server!
-   */
+  /// Have a custom chance of getting into the server!
   PERCENT,
 
-  /**
-   * Kick a player while joining!
-   */
+  /// Kick a player while joining!
   KICK
 }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/LoadBalancingStrategy.java

@@ -19,23 +19,15 @@
  */
 package net.pistonmaster.pistonqueue.shared.queue;
 
-/**
- * Strategy for selecting which queue server to send players to when multiple
- * queue servers are configured for a queue group.
- */
+/// Strategy for selecting which queue server to send players to when multiple
+/// queue servers are configured for a queue group.
 public enum LoadBalancingStrategy {
-  /**
-   * Alternates between queue servers in order.
-   */
+  /// Alternates between queue servers in order.
   ROUND_ROBIN,
 
-  /**
-   * Sends players to the queue server with the fewest connected players.
-   */
+  /// Sends players to the queue server with the fewest connected players.
   LEAST_PLAYERS,
 
-  /**
-   * Randomly selects a queue server.
-   */
+  /// Randomly selects a queue server.
   RANDOM
 }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/QueueGroup.java

@@ -24,40 +24,27 @@
 import java.util.List;
 import java.util.Locale;
 
-public final class QueueGroup {
-  private final String name;
-  private final List<String> queueServers;
-  private final List<String> targetServers;
-  private final List<String> sourceServers;
-  private final QueueType[] queueTypes;
-
+public record QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, QueueType[] queueTypes) {
   public QueueGroup(String name, List<String> queueServers, List<String> targetServers, List<String> sourceServers, QueueType[] queueTypes) {
     this.name = name;
-    this.queueServers = Collections.unmodifiableList(new ArrayList<>(queueServers));
-    this.targetServers = Collections.unmodifiableList(new ArrayList<>(targetServers));
-    this.sourceServers = Collections.unmodifiableList(new ArrayList<>(sourceServers));
+    this.queueServers = List.copyOf(queueServers);
+    this.targetServers = List.copyOf(targetServers);
+    this.sourceServers = List.copyOf(sourceServers);
     this.queueTypes = queueTypes == null ? new QueueType[0] : queueTypes.clone();
   }
 
-  public String getName() {
-    return name;
-  }
-
-  /**
-   * Returns all queue servers configured for this group.
-   *
-   * @return an unmodifiable list of queue server names
-   */
-  public List<String> getQueueServers() {
+  /// Returns all queue servers configured for this group.
+  ///
+  /// @return an unmodifiable list of queue server names
+  @Override
+  public List<String> queueServers() {
     return queueServers;
   }
 
-  /**
-   * Checks if the given server name is one of this group's queue servers.
-   *
-   * @param server the server name to check (case-insensitive)
-   * @return true if the server is a queue server for this group
-   */
+  /// Checks if the given server name is one of this group's queue servers.
+  ///
+  /// @param server the server name to check (case-insensitive)
+  /// @return true if the server is a queue server for this group
   public boolean hasQueueServer(String server) {
     if (server == null) {
       return false;
@@ -67,15 +54,8 @@ public boolean hasQueueServer(String server) {
       .anyMatch(qs -> qs.toLowerCase(Locale.ROOT).equals(lowerServer));
   }
 
-  public List<String> getTargetServers() {
-    return targetServers;
-  }
-
-  public List<String> getSourceServers() {
-    return sourceServers;
-  }
-
-  public QueueType[] getQueueTypes() {
+  @Override
+  public QueueType[] queueTypes() {
     return queueTypes.clone();
   }
 }

shared/src/main/java/net/pistonmaster/pistonqueue/shared/queue/logic/KickEventHandler.java

@@ -29,9 +29,7 @@
 import java.util.Objects;
 import java.util.concurrent.locks.Lock;
 
-/**
- * Handles kick events and potentially redirects players to the queue.
- */
+/// Handles kick events and potentially redirects players to the queue.
 public final class KickEventHandler {
   private final Config config;
   private final QueueEnvironment queueEnvironment;
@@ -43,20 +41,18 @@ public KickEventHandler(Config config, QueueEnvironment queueEnvironment, QueueS
     this.queueServerSelector = Objects.requireNonNull(queueServerSelector, "queueServerSelector");
   }
 
-  /**
-   * Handles a kick event, potentially redirecting the player to the queue if they were kicked
-   * from a protected target server due to it being down.
-   *
-   * @param event the kick event
-   */
+  /// Handles a kick event, potentially redirecting the player to the queue if they were kicked
+  /// from a protected target server due to it being down.
+  ///
+  /// @param event the kick event
   public void handleKick(PQKickedFromServerEvent event) {
     handleQueueRedirection(event);
     handleKickMessage(event);
   }
 
   private void handleQueueRedirection(PQKickedFromServerEvent event) {
     QueueGroup group = queueEnvironment.resolveGroupForTarget(event.getKickedFrom());
-    boolean kickedFromProtectedTarget = group.getTargetServers().contains(event.getKickedFrom());
+    boolean kickedFromProtectedTarget = group.targetServers().contains(event.getKickedFrom());
 
     if (config.ifTargetDownSendToQueue() && kickedFromProtectedTarget) {
       String kickReason = event.getKickReason()