fix(cli): satisfy golangci-lint (errcheck, unused, errorlint, ineffassign)

Ignore RegisterFlagCompletionFunc errors like other commands; drop unused
projectCredentialEnvValues wrapper; call redactTelemetryFields from noop
telemetry sinks; use errors.As in agent_infer test helper; fix separator
init in agent rule append path.

Author: digitallysavvy

internal/cli/agent_infer_test.go

@@ -1,6 +1,9 @@
 package cli
 
-import "testing"
+import (
+	"errors"
+	"testing"
+)
 
 func TestAgentLabelFromOSEnv(t *testing.T) {
 	tests := []struct {
@@ -92,8 +95,9 @@ func asCliError(err error, target **cliError) bool {
 	if err == nil {
 		return false
 	}
-	if c, ok := err.(*cliError); ok {
-		*target = c
+	var ce *cliError
+	if errors.As(err, &ce) {
+		*target = ce
 		return true
 	}
 	return false

internal/cli/agent_rules.go

@@ -139,13 +139,11 @@ func writeOrAppendAgentRuleBlock(path, body, target string) (string, error) {
 		}
 		return "updated", nil
 	}
-	separator := "\n"
+	var separator string
 	if len(existing) > 0 && existing[len(existing)-1] != '\n' {
 		separator = "\n\n"
 	} else if len(existing) >= 2 && string(existing[len(existing)-2:]) != "\n\n" {
 		separator = "\n"
-	} else {
-		separator = ""
 	}
 	next := append([]byte{}, existing...)
 	next = append(next, []byte(separator)...)

internal/cli/projects.go

@@ -549,10 +549,6 @@ func credentialLayoutFromProjectType(projectType string) projectEnvCredentialLay
 	}
 }
 
-func projectCredentialEnvValues(project projectDetail) (map[string]any, error) {
-	return projectCredentialEnvValuesForLayout(project, projectEnvLayoutStandard)
-}
-
 func projectCredentialEnvValuesForLayout(project projectDetail, layout projectEnvCredentialLayout) (map[string]any, error) {
 	if project.SignKey == nil || *project.SignKey == "" {
 		return nil, &cliError{Message: fmt.Sprintf("project %q does not have an app certificate. Enable one in Agora Console or use a different project with `agora project use`.", project.Name), Code: "PROJECT_NO_CERTIFICATE"}

internal/cli/skills.go

@@ -194,10 +194,10 @@ func (a *App) buildSkillsListCommand() *cobra.Command {
 	}
 	cmd.Flags().StringVar(&category, "category", "", "filter by category (scaffold, ops, agent)")
 	cmd.Flags().StringVar(&tag, "tag", "", "filter by tag (e.g. nextjs, rtc, mcp)")
-	cmd.RegisterFlagCompletionFunc("category", func(_ *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	_ = cmd.RegisterFlagCompletionFunc("category", func(_ *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return completeSkillCategories(toComplete), cobra.ShellCompDirectiveNoFileComp
 	})
-	cmd.RegisterFlagCompletionFunc("tag", func(_ *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	_ = cmd.RegisterFlagCompletionFunc("tag", func(_ *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return completeSkillTags(toComplete), cobra.ShellCompDirectiveNoFileComp
 	})
 	return cmd

internal/cli/telemetry.go

@@ -89,8 +89,14 @@ type versionInformation = map[string]any
 type noopTelemetry struct{}
 
 func (noopTelemetry) Enabled() bool                              { return false }
-func (noopTelemetry) CaptureException(_ error, _ map[string]any) {}
-func (noopTelemetry) CaptureEvent(_, _ string, _ map[string]any) {}
+func (noopTelemetry) CaptureException(_ error, fields map[string]any) {
+	// Contract: redact before any sink transports fields; keep call so
+	// redactTelemetryFields stays covered until Sentry wiring lands.
+	_ = redactTelemetryFields(fields)
+}
+func (noopTelemetry) CaptureEvent(_, _ string, fields map[string]any) {
+	_ = redactTelemetryFields(fields)
+}
 func (noopTelemetry) Flush(_ time.Duration) bool                 { return true }
 
 // sentryClient is the placeholder for the Sentry-backed sink. Until the