Skip to content

Commit 7e8d3bd

Browse files
committed
Fix release publish workflow
1 parent 11a1dfd commit 7e8d3bd

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ jobs:
232232
shell: bash
233233
env:
234234
GH_TOKEN: ${{ github.token }}
235+
GH_REPO: ${{ github.repository }}
235236
TAG: ${{ needs.prepare.outputs.tag }}
236237
VERSION: ${{ needs.prepare.outputs.version }}
237238
PRERELEASE: ${{ needs.prepare.outputs.prerelease }}

docs/work-log.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 2026-05-12
44

55
- Prepared `v3.1.0` release metadata on the `release` branch. Bumped the app-facing versions in `package.json`, `src-tauri/tauri.conf.json`, and `src-tauri/Cargo.toml`, kept workspace crate versions and `Cargo.lock` aligned at `3.1.0`, and verified the release workflow version guard against `v3.1.0`. Validation: `cargo check --workspace`, `pnpm check`, and `git diff --check` passed.
6+
- Fixed the release workflow publish job after the first `v3.1.0` tag run built macOS and Windows artifacts successfully but failed at `gh release` because the publish job had no repository context. The workflow now sets `GH_REPO` explicitly for GitHub CLI release commands. Validation: workflow YAML parsed with Ruby and `git diff --check` passed.
67
- Replaced the stale Windows-only manual GitHub Actions workflow with a tag-driven `Release` workflow. The new workflow validates SemVer tags, requires the tagged commit to be reachable from `origin/release`, verifies `src-tauri/tauri.conf.json`, `package.json`, and `src-tauri/Cargo.toml` versions match the tag, builds unsigned Tauri bundles on macOS and Windows, generates platform checksum files, uploads workflow artifacts, and creates prereleases for `-rc` tags or draft releases for final tags. Added `docs/todos/2026-05-12.00.automate-release-artifacts-with-github-actions.md` for the release automation plan. Validation: workflow YAML parsed with Ruby, local version guard script passed for `v3.0.0`, `pnpm tauri build` produced the macOS `.dmg`, `pnpm check`, and `git diff --check` passed. Windows runner and GitHub release publication still need validation on the first pushed release tag.
78
- Removed the Library toolbar's separate `Scan Local` button now that account sync runs local folder scan/hydration after successful remote sync. The Tauri command remains available for support/testing, but the frontend now presents Sync as the single refresh action. Updated the unified product-list design note. Validation: `pnpm check`, `pnpm build`, and `git diff --check` passed. Did not restart or stop the already-running dev process per user preference.
89
- Integrated local-only library scanning into the account sync job. `start_account_sync` now records whether a local scan is planned, performs a best-effort scan/hydration of configured library folders after successful DLsite account sync, returns structured local-scan output on the job, and keeps explicit `Scan Local` using the same audit detail shape. Updated the background-job and unified product-list design notes to preserve the app-level orchestration boundary. Validation: `cargo fmt --all`, `cargo check -p dlsite-manager`, `cargo test -p dlsite-manager`, `cargo check --workspace`, and `git diff --check` passed. Did not restart or stop the already-running dev process per user preference.

0 commit comments

Comments
 (0)