Use the constructor and fix a bug

Author: D8H

newIDE/app/src/MainFrame/EditorContainers/CustomObjectEditorContainer.js

@@ -52,6 +52,11 @@ export class CustomObjectEditorContainer extends React.Component<RenderEditorCon
     gd.ObjectsContainer.Function
   );
 
+  constructor(props: RenderEditorContainerProps) {
+    super(props);
+    this._rebuildProjectScopedContainersAccessor();
+  }
+
   getProject(): ?gdProject {
     return this.props.project;
   }
@@ -77,7 +82,6 @@ export class CustomObjectEditorContainer extends React.Component<RenderEditorCon
   }
 
   componentDidMount() {
-    this._rebuildProjectScopedContainersAccessor();
     if (this.props.isActive) {
       this._setPreviewedLayout();
     }

newIDE/app/src/MainFrame/EditorContainers/EventsEditorContainer.js

@@ -28,6 +28,11 @@ export class EventsEditorContainer extends React.Component<RenderEditorContainer
   _projectScopedContainersAccessor: ProjectScopedContainersAccessor | null = null;
   _scope: EventsScope | null = null;
 
+  constructor(props: RenderEditorContainerProps) {
+    super(props);
+    this._rebuildProjectScopedContainersAccessor();
+  }
+
   shouldComponentUpdate(nextProps: RenderEditorContainerProps): any {
     // We stop updates when the component is inactive.
     // If it's active, was active or becoming active again we let update propagate.
@@ -48,7 +53,6 @@ export class EventsEditorContainer extends React.Component<RenderEditorContainer
   }
 
   componentDidMount() {
-    this._rebuildProjectScopedContainersAccessor();
     if (this.props.isActive) {
       this._setPreviewedLayout();
     }

newIDE/app/src/MainFrame/EditorContainers/ExternalEventsEditorContainer.js

@@ -67,6 +67,11 @@ export class ExternalEventsEditorContainer extends React.Component<
     externalPropertiesDialogOpen: false,
   };
 
+  constructor(props: RenderEditorContainerProps) {
+    super(props);
+    this._rebuildProjectScopedContainersAccessor();
+  }
+
   shouldComponentUpdate(nextProps: RenderEditorContainerProps): any {
     // We stop updates when the component is inactive.
     // If it's active, was active or becoming active again we let update propagate.
@@ -81,12 +86,12 @@ export class ExternalEventsEditorContainer extends React.Component<
       this.props.projectItemName !== prevProps.projectItemName ||
       this._associatedLayoutName !== associatedLayoutName
     ) {
+      this._associatedLayoutName = associatedLayoutName;
       this._rebuildProjectScopedContainersAccessor();
     }
   }
 
   componentDidMount() {
-    this._rebuildProjectScopedContainersAccessor();
     this.resourceExternallyChangedCallbackId = registerOnResourceExternallyChangedCallback(
       this.onResourceExternallyChanged.bind(this)
     );
@@ -237,7 +242,7 @@ export class ExternalEventsEditorContainer extends React.Component<
     return project.getLayout(layoutName);
   }
 
-  getAssociatedLayoutName(): ?string {
+  getAssociatedLayoutName(): string | null {
     const { project } = this.props;
     if (!project) return null;
 

newIDE/app/src/MainFrame/EditorContainers/ExternalLayoutEditorContainer.js

@@ -66,6 +66,11 @@ export class ExternalLayoutEditorContainer extends React.Component<
     externalPropertiesDialogOpen: false,
   };
 
+  constructor(props: RenderEditorContainerProps) {
+    super(props);
+    this._rebuildProjectScopedContainersAccessor();
+  }
+
   getProject(): ?gdProject {
     return this.props.project;
   }
@@ -94,7 +99,6 @@ export class ExternalLayoutEditorContainer extends React.Component<
   }
 
   componentDidMount() {
-    this._rebuildProjectScopedContainersAccessor();
     if (this.props.isActive) {
       this._setPreviewedLayout();
     }

newIDE/app/src/MainFrame/EditorContainers/SceneEditorContainer.js

@@ -30,6 +30,11 @@ export class SceneEditorContainer extends React.Component<RenderEditorContainerP
   editor: ?SceneEditor;
   _projectScopedContainersAccessor: ProjectScopedContainersAccessor | null = null;
 
+  constructor(props: RenderEditorContainerProps) {
+    super(props);
+    this._rebuildProjectScopedContainersAccessor();
+  }
+
   getProject(): ?gdProject {
     return this.props.project;
   }
@@ -55,7 +60,6 @@ export class SceneEditorContainer extends React.Component<RenderEditorContainerP
   }
 
   componentDidMount() {
-    this._rebuildProjectScopedContainersAccessor();
     if (this.props.isActive) {
       this._setPreviewedLayout();
     }