Merge pull request #14 from 0neDistruktion/lab8-fix #38
0neDistruktionAnnotations
1 error and 10 warnings
|
Sonar Check
Process completed with exit code 1.
|
|
Sonar Check:
NetSdrClientApp/Messages/NetSdrMessageHelper.cs#L114
Use a constructor overloads that allows a more meaningful exception message to be provided. (https://rules.sonarsource.com/csharp/RSPEC-3928)
|
|
Sonar Check:
NetSdrClientApp/Networking/UdpClientWrapper.cs#L13
This class overrides 'GetHashCode' and should therefore also override 'Equals'. (https://rules.sonarsource.com/csharp/RSPEC-1206)
|
|
Sonar Check:
NetSdrClientApp/Networking/BaseClientWrapper.cs#L6
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
|
Sonar Check:
NetSdrClientApp/Networking/IUdpClient.cs#L2
Move 'IUdpClient' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
|
|
Sonar Check:
NetSdrClientApp/Networking/UdpClientWrapper.cs#L18
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
Sonar Check:
NetSdrClientApp/NetSdrClient.cs#L156
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Sonar Check:
NetSdrClientApp/Messages/NetSdrMessageHelper.cs#L10
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Sonar Check:
NetSdrClientApp/NetSdrClient.cs#L160
Cannot convert null literal to non-nullable reference type.
|
|
Sonar Check:
NetSdrClientApp/NetSdrClient.cs#L141
Possible null reference return.
|
|
Sonar Check:
NetSdrClientApp/NetSdrClient.cs#L22
Non-nullable field 'responseTaskSource' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
|